Skip to content

url: add value argument to has and delete methods #47885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 13 commits into from
May 14, 2023
Merged

url: add value argument to has and delete methods #47885

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
7d99ffc
url: add value argument to has and delete methods
sankalp1999 May 5, 2023
ecf95b5
url: add wpt tests
sankalp1999 May 5, 2023
5031f58
url: ran linter
sankalp1999 May 5, 2023
f1845e3
fixup! refactor delete method one loop into two for better readability
sankalp1999 May 6, 2023
2846704
url: refactor has method
sankalp1999 May 6, 2023
a0522c8
url: correction in hsa method, exact key-value tuple search
sankalp1999 May 6, 2023
3c1521f
doc: update has method and delete method
sankalp1999 May 6, 2023
e66fe1e
fixup! add changes in doc and refactor urlsearchparam-has
sankalp1999 May 6, 2023
68624b3
fixup! add default arg as undefined to value
sankalp1999 May 8, 2023
29c316c
tools: fix to accommodate base as null, benchmark test fixed
sankalp1999 May 8, 2023
9126a64
fixup! refactor delete method and minor correction in docs
sankalp1999 May 8, 2023
3b19423
url: refactor conditional statements in the loop
sankalp1999 May 8, 2023
fb0e57d
fixup! minor changes in docs
sankalp1999 May 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
tools: fix to accommodate base as null, benchmark test fixed
  • Loading branch information
@sankalp1999
sankalp1999 committed May 8, 2023
commit 29c316ca78843228bd31d62091c658fc2fa7d6d8
5 changes: 3 additions & 2 deletions benchmark/common.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -360,8 +360,9 @@ function getUrlData(withBase) {
for (const item of data) {
if (item.failure || !item.input) continue;
if (withBase) {
result.push([item.input, item.base]);
} else if (item.base !== 'about:blank') {
// item.base might be null. It should be converted into `undefined`.
result.push([item.input, item.base ?? undefined]);
} else if (item.base !== null) {
result.push(item.base);
}
}
Expand Down