-
-
Notifications
You must be signed in to change notification settings - Fork 34.8k
url: add value argument to has and delete methods #47885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
nodejs-github-bot
merged 13 commits into
nodejs:main
from
sankalp1999:url-search-param-has-delete
May 14, 2023
Merged
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
7d99ffc
url: add value argument to has and delete methods
sankalp1999 ecf95b5
url: add wpt tests
sankalp1999 5031f58
url: ran linter
sankalp1999 f1845e3
fixup! refactor delete method one loop into two for better readability
sankalp1999 2846704
url: refactor has method
sankalp1999 a0522c8
url: correction in hsa method, exact key-value tuple search
sankalp1999 3c1521f
doc: update has method and delete method
sankalp1999 e66fe1e
fixup! add changes in doc and refactor urlsearchparam-has
sankalp1999 68624b3
fixup! add default arg as undefined to value
sankalp1999 29c316c
tools: fix to accommodate base as null, benchmark test fixed
sankalp1999 9126a64
fixup! refactor delete method and minor correction in docs
sankalp1999 3b19423
url: refactor conditional statements in the loop
sankalp1999 fb0e57d
fixup! minor changes in docs
sankalp1999 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fixup! add changes in doc and refactor urlsearchparam-has
- Loading branch information
commit e66fe1e07328308bf535ffa510915952a1427a1e
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -859,7 +859,14 @@ new URLSearchParams([ | |||||
|
|
||||||
| Append a new name-value pair to the query string. | ||||||
|
|
||||||
| #### `urlSearchParams.delete(name, value)` | ||||||
| #### `urlSearchParams.delete(name[, value])` | ||||||
|
|
||||||
| <!-- YAML | ||||||
| changes: | ||||||
| - version: REPLACEME | ||||||
| pr-url: https://github.com/nodejs/node/pull/47885 | ||||||
| description: added optional value argument. | ||||||
| --> | ||||||
|
|
||||||
anonrig marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||
| * `name` {string} | ||||||
| * `value` {string} | ||||||
|
|
@@ -922,7 +929,14 @@ are no such pairs, `null` is returned. | |||||
| Returns the values of all name-value pairs whose name is `name`. If there are | ||||||
| no such pairs, an empty array is returned. | ||||||
|
|
||||||
| #### `urlSearchParams.has(name, value)` | ||||||
| #### `urlSearchParams.has(name[, value])` | ||||||
|
|
||||||
| <!-- YAML | ||||||
| changes: | ||||||
| - version: REPLACEME | ||||||
| pr-url: https://github.com/nodejs/node/pull/47885 | ||||||
| description: added optional value argument. | ||||||
|
||||||
| description: added optional value argument. | |
| description: Add support for optional `value` argument. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.