Review fixes for #2280#1
Merged
nucleogenesis merged 14 commits intonucleogenesis:icons-colors-fontsfrom Sep 25, 2020
Merged
Conversation
- Also ensure that all answers are cast to number type or removed when changing the kind of question it is.
- regex used to remove alphabetical answers when switching to question_input now accepts float and signed numbers - tests test that incorrect data is removed properly - tests also updated to account for using VTextField for question_input using shallowMount for one of the it() blocks since VTextField doesn't render output to the DOM with mount removed some vendor styles that the linter got mad about.
…only-for-input-question Input question on AnswerEdit is now a type=number field
…lidation-string update numeric validation string
KDS theme tokens contain `correct` field that is set to green (#43A047). Answers editor used this class to mark correct answers which introduced green background to them which should not be there.
to prevent height glitches on hover now when we use vertical options button instead of the horizontal one.
nucleogenesis
pushed a commit
that referenced
this pull request
Oct 17, 2022
Added more granular steps
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In this PR, I've been addressing some issues that would be good to have ready in develop before the bug hunt.