Skip to content

replaced viper with koanf, feature parity#44

Merged
woutslakhorst merged 16 commits into
masterfrom
iss4_replace_viper
Feb 4, 2021
Merged

replaced viper with koanf, feature parity#44
woutslakhorst merged 16 commits into
masterfrom
iss4_replace_viper

Conversation

@woutslakhorst

@woutslakhorst woutslakhorst commented Feb 2, 2021

Copy link
Copy Markdown
Member

closes #4

This PR focusses on removing viper and the reflection for config loading. It does not focus on refactoring engines and load/config ordering.

@codecov

codecov Bot commented Feb 2, 2021

Copy link
Copy Markdown

Codecov Report

Merging #44 (2e7478d) into master (60c38b5) will decrease coverage by 0.14%.
The diff coverage is 92.63%.

Impacted Files Coverage Δ
network/config.go 100.00% <ø> (ø)
vdr/config.go 0.00% <ø> (ø)
core/engine.go 86.95% <77.77%> (-2.52%) ⬇️
cmd/root.go 77.27% <85.71%> (+3.83%) ⬆️
core/config.go 93.87% <93.47%> (+6.69%) ⬆️
core/status.go 100.00% <100.00%> (+10.34%) ⬆️
crypto/engine/engine.go 80.00% <100.00%> (ø)
network/engine/engine.go 77.64% <100.00%> (+0.53%) ⬆️
vdr/engine/engine.go 82.95% <100.00%> (+0.39%) ⬆️

@woutslakhorst

Copy link
Copy Markdown
Member Author

drop in coverage is due to removing code....

Comment thread core/config.go Outdated
Comment thread core/config.go Outdated
Comment thread core/config.go Outdated
Comment thread core/config.go Outdated
@woutslakhorst
woutslakhorst merged commit f6055ab into master Feb 4, 2021
@woutslakhorst
woutslakhorst deleted the iss4_replace_viper branch February 4, 2021 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

remove config reflection

2 participants