Move engine datadir to core config#46
Merged
Merged
Conversation
Codecov Report
|
reinkrul
force-pushed
the
iss42-datadir-config
branch
3 times, most recently
from
February 4, 2021 12:48
10589aa to
bf53ab1
Compare
woutslakhorst
requested changes
Feb 4, 2021
woutslakhorst
left a comment
woutslakhorst
left a comment
Member
There was a problem hiding this comment.
- failing tests
- rebase on master?
- some documentation on which files to expect in the datadir?
reinkrul
force-pushed
the
iss42-datadir-config
branch
from
February 4, 2021 15:10
60f31a1 to
0e5a8e7
Compare
Member
Author
I documented it as part of backup recommedations in "running in production". |
woutslakhorst
requested changes
Feb 5, 2021
woutslakhorst
approved these changes
Feb 5, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In practice you'll probably want to have all data files in the same place, if not you can symlink them.
Fixes #42
Based on #44 (rebase first)