fix: backward compatible runtime env vars for client plugins#385
Closed
fix: backward compatible runtime env vars for client plugins#385
Conversation
pi0
reviewed
Jul 6, 2022
| req: event.req, | ||
| res: event.res, | ||
| runtimeConfig: { private: config, public: { public: config.public, app: config.app } }, | ||
| runtimeConfig: { private: config, public: { ...config.public, public: config.public, app: config.app } }, |
Member
There was a problem hiding this comment.
It should be handled by the runtime proxy.
Author
There was a problem hiding this comment.
As i understand runtime proxy is a config object itself that comes from composable useRuntimeConfig , but here its set values as a new object with public and app path, which nullify that proxy so it leads to no props at root like nuxt 2 expect. And thats the reason why composable works fine but not when getting $config from context
8 tasks
10 tasks
Member
Member
|
Closing as I think the root issue is solved, but please ping me if not 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
#9
❓ Type of change
📚 Description
allows access env vars in bridge via $store in plugins on client
📝 Checklist