Skip to content

fix: backward compatible runtime env vars for client plugins #385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aldarund wants to merge 1 commit into from
Closed

fix: backward compatible runtime env vars for client plugins #385

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/runtime/nitro/renderer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ export default eventHandler(async (event) => {
event,
req: event.req,
res: event.res,
runtimeConfig: { private: config, public: { public: config.public, app: config.app } },
runtimeConfig: { private: config, public: { ...config.public, public: config.public, app: config.app } },
Copy link
Copy Markdown
Member

@pi0 pi0 Jul 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be handled by the runtime proxy.

Copy link
Copy Markdown
Author

@aldarund aldarund Jul 6, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As i understand runtime proxy is a config object itself that comes from composable useRuntimeConfig , but here its set values as a new object with public and app path, which nullify that proxy so it leads to no props at root like nuxt 2 expect. And thats the reason why composable works fine but not when getting $config from context

noSSR: event.req.headers['x-nuxt-no-ssr'],

error: ssrError,
Expand Down