fix(nuxt)!: include request url and params in useFetch key#6632
Conversation
❌ Deploy Preview for nuxt3-docs failed.
|
247e18b to
c98e5c7
Compare
|
Any update on this @danielroe ? Last time we discussed i think we decided to combination of auto key and hash. |
|
@pi0 Sure! Would you summarise what the issues are from your point of view, apart from hashing the url key? |
|
Async data key to be |
|
How about instead: The reason is that any hash of input options is going to mismatch between server + client if any of those options are functions. |
|
By hash i mean url+query only not all options. seems good idea to allow entirely overriding with custom key 👍 |
|
excellent |
useFetch key
|
The fetch options key not working anymore! I think it broke it, please check again |
|
@examgoal Please create a new issue with reproduction |
🔗 Linked issue
resolves nuxt/nuxt#14493, resolves nuxt/nuxt#14499
❓ Type of change
📚 Description
A regression of #4955 - we were not using the URL as a key if it was provided. This PR uses the url as default key (including params and baseURL if provided).
There is still room for future improvement here via nuxt/nuxt#14583, for example, and I'll be following up with some more PRs targeting specific issues.
📝 Checklist