Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.

docs: add note about useFetch auto generated key#7044

Merged
pi0 merged 1 commit intonuxt:mainfrom
victorkwok97:chore/docs
Sep 3, 2022
Merged

docs: add note about useFetch auto generated key#7044
pi0 merged 1 commit intonuxt:mainfrom
victorkwok97:chore/docs

Conversation

@victorkwok97
Copy link
Copy Markdown
Contributor

🔗 Linked issue

#5895
#4955

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Documentation about how the default key is generated was not updated.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@netlify
Copy link
Copy Markdown

netlify Bot commented Aug 30, 2022

Deploy Preview for nuxt3-docs ready!

Name Link
🔨 Latest commit 9f911c8
🔍 Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/630db079c1540b00088cd249
😎 Deploy Preview https://deploy-preview-7044--nuxt3-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@pi0 pi0 requested a review from danielroe August 30, 2022 08:38
@pi0 pi0 changed the title chore(docs): update useFetch key description docs: add note about useFetch auto generated key Aug 30, 2022
@danielroe
Copy link
Copy Markdown
Member

(We will likely need to pend merging this PR depending on what @pi0 decides to do with #6632.)

@danielroe danielroe added documentation Improvements or additions to documentation pending labels Aug 30, 2022
@pi0
Copy link
Copy Markdown
Member

pi0 commented Aug 30, 2022

@danielroe Regardless we need to document behavior of of auto generated keys and it affects both asyncData and fetch. #6632 is effectively reverting auto key generation to previous code I've written that generated key based on URL. We can update docs by then to show this warning only about asyncData :)

@pi0 pi0 removed the pending label Aug 30, 2022
@pi0 pi0 merged commit 5650927 into nuxt:main Sep 3, 2022
@pi0
Copy link
Copy Markdown
Member

pi0 commented Sep 3, 2022

(we shall update docs if changing behavior for next rc)

This was referenced Sep 9, 2022
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

3.x documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants