Skip to content

Move quantization &quant_moe to new inf optimizer - #112

Merged
h-guo18 merged 7 commits into
feat/ad-2025-07-22from
haoguo/move_quantization
Jul 26, 2025
Merged

Move quantization &quant_moe to new inf optimizer#112
h-guo18 merged 7 commits into
feat/ad-2025-07-22from
haoguo/move_quantization

Conversation

@h-guo18

@h-guo18 h-guo18 commented Jul 24, 2025

Copy link
Copy Markdown

@coderabbitai summary

Description

#98

Test Coverage

  • unit test passed;
  • we runned trtllm-bench on the two codes with the script:
MODEL=TinyLlama/TinyLlama-1.1B-Chat-v1.0
python benchmarks/cpp/prepare_dataset.py --stdout --tokenizer $MODEL token-norm-dist --input-mean 128 --output-mean 128 --input-stdev 0 --output-stdev 0 --num-requests 1000 > /tmp/synthetic_128_128.txt
trtllm-bench --model $MODEL  throughput --dataset /tmp/synthetic_128_128.txt --backend _autodeploy --extra_llm_api_options bench.yaml --tp 1 --max_batch_size 512% 

target branch, single gpu:

Request Throughput (req/sec):                     37.7767
Total Output Throughput (tokens/sec):             4835.4131
Total Token Throughput (tokens/sec):              9670.8263
Total Latency (ms):                               26471.3679
Average request latency (ms):                     20739.2573
Per User Output Throughput [w/ ctx] (tps/user):   6.6542
Per GPU Output Throughput (tps/gpu):              4835.4131

with modification, single gpu:

Request Throughput (req/sec):                     37.9002
Total Output Throughput (tokens/sec):             4851.2312
Total Token Throughput (tokens/sec):              9702.4624
Total Latency (ms):                               26385.0547
Average request latency (ms):                     20682.6822
Per User Output Throughput [w/ ctx] (tps/user):   6.6697
Per GPU Output Throughput (tps/gpu):              4851.2312

taraget branch, tp=2:

Request Throughput (req/sec):                     26.3553
Total Output Throughput (tokens/sec):             3373.4720
Total Token Throughput (tokens/sec):              6746.9441
Total Latency (ms):                               37943.1038
Average request latency (ms):                     29529.1909
Per User Output Throughput [w/ ctx] (tps/user):   4.7028
Per GPU Output Throughput (tps/gpu):              1686.7360

with modification, tp=2:

Request Throughput (req/sec):                     26.4694
Total Output Throughput (tokens/sec):             3388.0773
Total Token Throughput (tokens/sec):              6776.1546
Total Latency (ms):                               37779.5395
Average request latency (ms):                     29411.8587
Per User Output Throughput [w/ ctx] (tps/user):   4.7197
Per GPU Output Throughput (tps/gpu):              1694.0386

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

Details

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@h-guo18 h-guo18 self-assigned this Jul 24, 2025
@h-guo18
h-guo18 requested a review from lucaslie July 24, 2025 06:53
@h-guo18
h-guo18 marked this pull request as ready for review July 24, 2025 06:53
@lucaslie
lucaslie requested a review from Fridah-nv July 24, 2025 15:37
Comment thread tensorrt_llm/_torch/auto_deploy/transform/library/quantization.py Outdated
Comment thread tensorrt_llm/_torch/auto_deploy/transform/library/quantize_moe.py Outdated
@h-guo18
h-guo18 force-pushed the haoguo/move_quantization branch from 4be0ff7 to 32f81a5 Compare July 25, 2025 23:19
h-guo18 and others added 7 commits July 26, 2025 05:39
Signed-off-by: haoguo <67671475+h-guo18@users.noreply.github.com>
Signed-off-by: haoguo <67671475+h-guo18@users.noreply.github.com>
Signed-off-by: haoguo <67671475+h-guo18@users.noreply.github.com>
Signed-off-by: haoguo <67671475+h-guo18@users.noreply.github.com>
Co-authored-by: Fridah-nv <201670829+Fridah-nv@users.noreply.github.com>
Signed-off-by: h-guo18 <67671475+h-guo18@users.noreply.github.com>
Signed-off-by: haoguo <67671475+h-guo18@users.noreply.github.com>
Signed-off-by: Frida Hou <201670829+Fridah-nv@users.noreply.github.com>
@h-guo18
h-guo18 force-pushed the haoguo/move_quantization branch from a71ad66 to 717ccda Compare July 26, 2025 06:17
@h-guo18
h-guo18 merged commit b47abb4 into feat/ad-2025-07-22 Jul 26, 2025
1 check passed
MrGeva pushed a commit that referenced this pull request Jul 29, 2025
* refactor: move quantization and quant_moe to new inf optimizer

Signed-off-by: haoguo <67671475+h-guo18@users.noreply.github.com>

* refactor: use quant_config from factory instead of new config type

Signed-off-by: haoguo <67671475+h-guo18@users.noreply.github.com>

* refactor: del old files; update default.yaml

Signed-off-by: haoguo <67671475+h-guo18@users.noreply.github.com>

* move helper class FakeFacotry to _graph_test_helpers.py

Signed-off-by: haoguo <67671475+h-guo18@users.noreply.github.com>

* polish: remove unreachable branch in quantization.py

Co-authored-by: Fridah-nv <201670829+Fridah-nv@users.noreply.github.com>
Signed-off-by: h-guo18 <67671475+h-guo18@users.noreply.github.com>

* style: run pre-commit

Signed-off-by: haoguo <67671475+h-guo18@users.noreply.github.com>

* fix to fetch hf_quant_config from fetched dir

Signed-off-by: Frida Hou <201670829+Fridah-nv@users.noreply.github.com>

---------

Signed-off-by: haoguo <67671475+h-guo18@users.noreply.github.com>
Signed-off-by: h-guo18 <67671475+h-guo18@users.noreply.github.com>
Signed-off-by: Frida Hou <201670829+Fridah-nv@users.noreply.github.com>
Co-authored-by: Fridah-nv <201670829+Fridah-nv@users.noreply.github.com>
h-guo18 added a commit that referenced this pull request Jul 30, 2025
* refactor: move quantization and quant_moe to new inf optimizer

Signed-off-by: haoguo <67671475+h-guo18@users.noreply.github.com>

* refactor: use quant_config from factory instead of new config type

Signed-off-by: haoguo <67671475+h-guo18@users.noreply.github.com>

* refactor: del old files; update default.yaml

Signed-off-by: haoguo <67671475+h-guo18@users.noreply.github.com>

* move helper class FakeFacotry to _graph_test_helpers.py

Signed-off-by: haoguo <67671475+h-guo18@users.noreply.github.com>

* polish: remove unreachable branch in quantization.py

Co-authored-by: Fridah-nv <201670829+Fridah-nv@users.noreply.github.com>
Signed-off-by: h-guo18 <67671475+h-guo18@users.noreply.github.com>

* style: run pre-commit

Signed-off-by: haoguo <67671475+h-guo18@users.noreply.github.com>

* fix to fetch hf_quant_config from fetched dir

Signed-off-by: Frida Hou <201670829+Fridah-nv@users.noreply.github.com>

---------

Signed-off-by: haoguo <67671475+h-guo18@users.noreply.github.com>
Signed-off-by: h-guo18 <67671475+h-guo18@users.noreply.github.com>
Signed-off-by: Frida Hou <201670829+Fridah-nv@users.noreply.github.com>
Co-authored-by: Fridah-nv <201670829+Fridah-nv@users.noreply.github.com>
lucaslie pushed a commit that referenced this pull request Jul 31, 2025
* refactor: move quantization and quant_moe to new inf optimizer

Signed-off-by: haoguo <67671475+h-guo18@users.noreply.github.com>

* refactor: use quant_config from factory instead of new config type

Signed-off-by: haoguo <67671475+h-guo18@users.noreply.github.com>

* refactor: del old files; update default.yaml

Signed-off-by: haoguo <67671475+h-guo18@users.noreply.github.com>

* move helper class FakeFacotry to _graph_test_helpers.py

Signed-off-by: haoguo <67671475+h-guo18@users.noreply.github.com>

* polish: remove unreachable branch in quantization.py

Co-authored-by: Fridah-nv <201670829+Fridah-nv@users.noreply.github.com>
Signed-off-by: h-guo18 <67671475+h-guo18@users.noreply.github.com>

* style: run pre-commit

Signed-off-by: haoguo <67671475+h-guo18@users.noreply.github.com>

* fix to fetch hf_quant_config from fetched dir

Signed-off-by: Frida Hou <201670829+Fridah-nv@users.noreply.github.com>

---------

Signed-off-by: haoguo <67671475+h-guo18@users.noreply.github.com>
Signed-off-by: h-guo18 <67671475+h-guo18@users.noreply.github.com>
Signed-off-by: Frida Hou <201670829+Fridah-nv@users.noreply.github.com>
Co-authored-by: Fridah-nv <201670829+Fridah-nv@users.noreply.github.com>
Fridah-nv added a commit that referenced this pull request Jul 31, 2025
* refactor: move quantization and quant_moe to new inf optimizer

Signed-off-by: haoguo <67671475+h-guo18@users.noreply.github.com>

* refactor: use quant_config from factory instead of new config type

Signed-off-by: haoguo <67671475+h-guo18@users.noreply.github.com>

* refactor: del old files; update default.yaml

Signed-off-by: haoguo <67671475+h-guo18@users.noreply.github.com>

* move helper class FakeFacotry to _graph_test_helpers.py

Signed-off-by: haoguo <67671475+h-guo18@users.noreply.github.com>

* polish: remove unreachable branch in quantization.py

Co-authored-by: Fridah-nv <201670829+Fridah-nv@users.noreply.github.com>
Signed-off-by: h-guo18 <67671475+h-guo18@users.noreply.github.com>

* style: run pre-commit

Signed-off-by: haoguo <67671475+h-guo18@users.noreply.github.com>

* fix to fetch hf_quant_config from fetched dir

Signed-off-by: Frida Hou <201670829+Fridah-nv@users.noreply.github.com>

---------

Signed-off-by: haoguo <67671475+h-guo18@users.noreply.github.com>
Signed-off-by: h-guo18 <67671475+h-guo18@users.noreply.github.com>
Signed-off-by: Frida Hou <201670829+Fridah-nv@users.noreply.github.com>
Co-authored-by: Fridah-nv <201670829+Fridah-nv@users.noreply.github.com>
Fridah-nv added a commit that referenced this pull request Jul 31, 2025
* refactor: move quantization and quant_moe to new inf optimizer

Signed-off-by: haoguo <67671475+h-guo18@users.noreply.github.com>

* refactor: use quant_config from factory instead of new config type

Signed-off-by: haoguo <67671475+h-guo18@users.noreply.github.com>

* refactor: del old files; update default.yaml

Signed-off-by: haoguo <67671475+h-guo18@users.noreply.github.com>

* move helper class FakeFacotry to _graph_test_helpers.py

Signed-off-by: haoguo <67671475+h-guo18@users.noreply.github.com>

* polish: remove unreachable branch in quantization.py

Co-authored-by: Fridah-nv <201670829+Fridah-nv@users.noreply.github.com>
Signed-off-by: h-guo18 <67671475+h-guo18@users.noreply.github.com>

* style: run pre-commit

Signed-off-by: haoguo <67671475+h-guo18@users.noreply.github.com>

* fix to fetch hf_quant_config from fetched dir

Signed-off-by: Frida Hou <201670829+Fridah-nv@users.noreply.github.com>

---------

Signed-off-by: haoguo <67671475+h-guo18@users.noreply.github.com>
Signed-off-by: h-guo18 <67671475+h-guo18@users.noreply.github.com>
Signed-off-by: Frida Hou <201670829+Fridah-nv@users.noreply.github.com>
Co-authored-by: Fridah-nv <201670829+Fridah-nv@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants