[Issue #4403][refactor] Move pattern matching transforms to new InferenceOptimizer - #98
Closed
h-guo18 wants to merge 14 commits into
Closed
[Issue #4403][refactor] Move pattern matching transforms to new InferenceOptimizer#98h-guo18 wants to merge 14 commits into
h-guo18 wants to merge 14 commits into
Conversation
Signed-off-by: haoguo <67671475+h-guo18@users.noreply.github.com>
Signed-off-by: haoguo <67671475+h-guo18@users.noreply.github.com>
Signed-off-by: haoguo <67671475+h-guo18@users.noreply.github.com>
h-guo18
changed the title
h-guo18
changed the title
h-guo18
changed the title
Signed-off-by: haoguo <67671475+h-guo18@users.noreply.github.com>
Signed-off-by: haoguo <67671475+h-guo18@users.noreply.github.com>
Signed-off-by: haoguo <67671475+h-guo18@users.noreply.github.com>
h-guo18
marked this pull request as draft
July 20, 2025 21:29
Signed-off-by: haoguo <67671475+h-guo18@users.noreply.github.com>
Signed-off-by: haoguo <67671475+h-guo18@users.noreply.github.com>
h-guo18
changed the title
Signed-off-by: haoguo <67671475+h-guo18@users.noreply.github.com>
Signed-off-by: haoguo <67671475+h-guo18@users.noreply.github.com>
lucaslie
reviewed
Jul 22, 2025
lucaslie
left a comment
lucaslie
left a comment
There was a problem hiding this comment.
For any transform that we move we should:
- remove the corresponding transform from the old InferenceOptimizer
- configure the default settings in
auto_deploy/config/default.yaml
Once we have finalized the reviews, would you be comfortable submitting one PR per transform? (or at least one PR per a couple of transforms). This well help with tracking potential regressions in case we face any
|
|
||
| # TODO:(hg) confirm this | ||
| info = TransformInfo( | ||
| skipped=False, num_matches=num_moe_patterns, is_clean=False, has_valid_shapes=True |
There was a problem hiding this comment.
Suggested change
| skipped=False, num_matches=num_moe_patterns, is_clean=False, has_valid_shapes=True | |
| skipped=False, num_matches=num_moe_patterns, is_clean=False, has_valid_shapes=False |
This is safer unless we know that the transform correctly assigns and updates shapes.
@Fridah-nv can also comment on that
There was a problem hiding this comment.
I agree on this. I think all the transformations should be able to preserve valid shapes except for those using torch._inductor pattern matcher.
Should we require the other transformations to preserve it to avoid running shape propagation multiple times? cc: @lucaslie
|
|
||
| # TODO:(hg) confirm this | ||
| info = TransformInfo( | ||
| skipped=False, num_matches=fused_key_counter, is_clean=False, has_valid_shapes=True |
There was a problem hiding this comment.
Suggested change
| skipped=False, num_matches=fused_key_counter, is_clean=False, has_valid_shapes=True | |
| skipped=False, num_matches=fused_key_counter, is_clean=False, has_valid_shapes=False |
@Fridah-nv can also comment on this
|
|
||
| # TODO:(hg) confirm this | ||
| info = TransformInfo( | ||
| skipped=False, num_matches=num_matches, is_clean=False, has_valid_shapes=True |
There was a problem hiding this comment.
@Fridah-nv please help confirm @h-guo18 as well
There was a problem hiding this comment.
has_valid_shapes should be set to False since the pattern matcher utility won't preserve shape information correctly
Signed-off-by: haoguo <67671475+h-guo18@users.noreply.github.com>
Signed-off-by: haoguo <67671475+h-guo18@users.noreply.github.com>
Signed-off-by: haoguo <67671475+h-guo18@users.noreply.github.com>
Signed-off-by: haoguo <67671475+h-guo18@users.noreply.github.com>
This was referenced Jul 23, 2025
This was referenced Jul 24, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GH Issue #4403 [refactor] Move pattern matching transforms to new InferenceOptimizer
Description
Test Coverage
Unite tests. See changed files.