chore: Refactor internal/version into root version folder#3145
Merged
dpaasman00 merged 4 commits intomainfrom Feb 17, 2026
Merged
Conversation
mrsillydog
approved these changes
Feb 17, 2026
Comment on lines
+122
to
+123
| func createDefaultConfig() func() component.Config { | ||
| collectorVersion := version.Version() |
Contributor
There was a problem hiding this comment.
This should be able to just return a config now as opposed to returning a function
Comment on lines
+111
to
+112
| func createDefaultConfig() func() component.Config { | ||
| collectorVersion := version.Version() |
exporter/webhookexporter/factory.go
Outdated
Comment on lines
+50
to
+51
| func createDefaultConfig() func() component.Config { | ||
| userAgent := fmt.Sprintf("%s/%s", defaultUserAgent, version.Version()) |
dpaasman00
deleted the
dakotapaasman/bpop-4553-refactor-components-importing-version-pkg
branch
dpaasman00
added a commit
that referenced
this pull request
Feb 17, 2026
* refactor internal/version into root version folder * update component doc for ocb use case * ci * dont return cfg func
dpaasman00
added a commit
that referenced
this pull request
Feb 17, 2026
* chore: Refactor `internal/version` into root `version` folder (#3145) * refactor internal/version into root version folder * update component doc for ocb use case * ci * dont return cfg func * update manifests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Change
Moves the
internal/versionpackage into a new package at the root of the repo. Updates the 3 components that previously used this package to use the new root level package.This is necessary to make these components compatible with the OCB.
Checklist