Skip to content

Update libevent under Windows#27553

Merged
mseri merged 1 commit intoocaml:masterfrom
mtelvers:libevent
Mar 6, 2025
Merged

Update libevent under Windows#27553
mseri merged 1 commit intoocaml:masterfrom
mtelvers:libevent

Conversation

@mtelvers
Copy link
Contributor

@mtelvers mtelvers commented Mar 4, 2025

No description provided.

@thatportugueseguy
Copy link
Contributor

Why is the CI failing due to lack of source directories if the packages all have the correct conf flag?

@mtelvers
Copy link
Contributor Author

mtelvers commented Mar 6, 2025

It is because of a bug in opam-repo-ci. See ocurrent/opam-repo-ci#420. The PR was merged after the CI ran.

@shonfeder
Copy link
Member

ocurrent/opam-repo-ci#420 has also not been deployed yet. I'll fix this!

@shonfeder shonfeder self-assigned this Mar 6, 2025
@thatportugueseguy
Copy link
Contributor

thanks for the explanation!

@mseri
Copy link
Member

mseri commented Mar 6, 2025

Thanks!

@mseri mseri merged commit 4c09466 into ocaml:master Mar 6, 2025
1 of 2 checks passed
Comment on lines -8 to +16
["pkg-config" "--exists" "libevent"]
"pkgconf" {os = "win32" & os-distribution != "cygwinports"}
"--personality=i686-w64-mingw32"
{os = "win32" & os-distribution != "cygwinports" &
host-arch-x86_32:installed}
"--personality=x86_64-w64-mingw32"
{os = "win32" & os-distribution != "cygwinports" &
host-arch-x86_64:installed}
"pkg-config" {os != "Win32" | os-distribution != "cygwin"}
"libevent"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this dropped (on the non-win32 or cygwin) the --exists flag between pkg-config and libevent -- was this intentional?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the man page, --exists is implied when no other option is specified.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mtelvers Thanks for your comment. Since there are at least three pkg-config implementations, I'm not sure which one you're talking about. I find it very brittle to rely on the documented default of one of the pkg-config implementations.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've had a quick check, and it seems to be the default in all of these implementations. There are multiple occurrences in opam-repository both with and without --exists and a variety of other parameters. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants