-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Update libevent under Windows #27553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 changes: 20 additions & 0 deletions
20
packages/conf-mingw-w64-libevent-i686/conf-mingw-w64-libevent-i686.1/opam
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| opam-version: "2.0" | ||
| homepage: "https://libevent.org" | ||
| authors: ["Libevent dev team"] | ||
| license: "BSD-3-clause" | ||
| bug-reports: "https://github.com/ocaml/opam-repository/issues" | ||
| flags: conf | ||
| available: os = "win32" | ||
| build: ["pkgconf" "--personality=i686-w64-mingw32" "libevent"] | ||
| depends: [ | ||
| "conf-pkg-config" {build} | ||
| "conf-mingw-w64-gcc-i686" {build} | ||
| ] | ||
| synopsis: "Libevent for i686 mingw-w64" | ||
| description: | ||
| "Ensure the i686 version of libevent for the mingw-w64 project is available" | ||
| maintainer: "David Allsopp <david@tarides.com>" | ||
| depexts: [ | ||
| ["mingw64-i686-libevent"] {os = "win32" & os-distribution = "cygwin"} | ||
| ["mingw-w64-i686-libevent"] {os = "win32" & os-distribution = "msys2"} | ||
| ] |
21 changes: 21 additions & 0 deletions
21
packages/conf-mingw-w64-libevent-x86_64/conf-mingw-w64-libevent-x86_64.1/opam
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| opam-version: "2.0" | ||
| homepage: "https://libevent.org" | ||
| authors: ["Libevent dev team"] | ||
| license: "BSD-3-clause" | ||
| bug-reports: "https://github.com/ocaml/opam-repository/issues" | ||
| flags: conf | ||
| available: os = "win32" | ||
| build: ["pkgconf" "--personality=x86_64-w64-mingw32" "libevent"] | ||
| depends: [ | ||
| "conf-pkg-config" {build} | ||
| "conf-mingw-w64-gcc-x86_64" {build} | ||
| ] | ||
| synopsis: "Libevent for x86_64 mingw-w64" | ||
| description: | ||
| "Ensure the x86_64 version of libevent for the mingw-w64 project is available" | ||
| maintainer: "David Allsopp <david@tarides.com>" | ||
| depexts: [ | ||
| ["mingw64-x86_64-libevent"] {os = "win32" & os-distribution = "cygwin"} | ||
| ["mingw-w64-x86_64-libevent"] {os = "win32" & os-distribution = "msys2"} | ||
| ] | ||
|
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this dropped (on the non-win32 or cygwin) the
--existsflag betweenpkg-configandlibevent-- was this intentional?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From the man page,
--existsis implied when no other option is specified.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mtelvers Thanks for your comment. Since there are at least three pkg-config implementations, I'm not sure which one you're talking about. I find it very brittle to rely on the documented default of one of the pkg-config implementations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW: http://pkg-config.freedesktop.org/ https://github.com/pkgconf/pkgconf https://metacpan.org/release/PkgConfig
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've had a quick check, and it seems to be the default in all of these implementations. There are multiple occurrences in opam-repository both with and without
--existsand a variety of other parameters. :-)