Bump actions/github-script from 7 to 8 - #4
Merged
justinchuby merged 1 commit intoMar 20, 2026
Conversation
Bumps [actions/github-script](https://github.com/actions/github-script) from 7 to 8. - [Release notes](https://github.com/actions/github-script/releases) - [Commits](actions/github-script@v7...v8) --- updated-dependencies: - dependency-name: actions/github-script dependency-version: '8' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
added
dependencies
Performance Comparison
|
justinchuby
approved these changes
Mar 20, 2026
justinchuby
deleted the
dependabot/github_actions/actions/github-script-8
branch
March 20, 2026 18:38
justinchuby
added a commit
that referenced
this pull request
Apr 13, 2026
…tion, embed_scale Issue #4: Remove extra post_layernorm from _Gemma4VisionEncoderCore. HF Gemma4VisionEncoder has no post-encoder norm. The scale-free RMSNorm (embedding_pre_projection_norm) lives only in _Gemma4VisionEncoderModel as projector_norm, applied once before the projector. Issue #5: Zero padding patches and pass attention mask to vision encoder. Detect pixel_position_ids == -1 in _Gemma4VisionPatchEmbedder; zero position embeddings for those patches (matching HF _position_embeddings). Build additive attention bias [B,1,1,N] with -1e9 for padding columns and thread it through Gemma4VisionEncoderLayer -> Gemma4VisionSelfAttention -> op.Attention. After all encoder layers, zero padding patch hidden states before scaling/norm/projection (matching HF VisionPooler masked_fill). Issue #6: Replace Softmax with arithmetic normalization for MoE top-k weights. HF: top_k_weights /= top_k_weights.sum(-1, keepdim=True). We were using op.Softmax which applies exponential re-weighting. Fix: op.ReduceSum + op.Div. Issue #7: Remove np.float16 cast on embed_scale. HF uses hidden_size**0.5 as exact float32. np.float16 introduces ~0.01% rounding error on every embedding lookup. Use math.sqrt() instead. Both occurrences fixed (_Gemma4TextModel and Gemma4EmbeddingModel). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
justinchuby
added a commit
that referenced
this pull request
May 4, 2026
… tests (#240) Addresses 4 review comments from PR #239: ### 1. GQA rewrite rule head_dim limit (#1) Updated `_MAX_GQA_HEAD_DIM` from 256 to 512 in the Attention→GQA rewrite rule to match latest ORT support for head_dim=512. ### 2. GGUF path missing `attention_k_eq_v` (#2) Added `attention_k_eq_v=True` to Gemma4 GGUF postprocessor when `num_global_key_value_heads` is detected. Fixes `build_from_gguf()` for 26b-a4b/31b checkpoints. ### 3. DRY expert weight rename (#3) Extracted `_remap_moe_expert_weights()` shared helper used by both `Gemma4CausalLMModel.preprocess_weights()` and `Gemma4Model.preprocess_weights()`. Single source of truth for expert rename + router scale folding. ### 4. Missing multimodal preprocess_weights test (#4) Added `gemma4_test.py` with 5 targeted tests covering both `Gemma4CausalLMModel` and `Gemma4Model` weight preprocessing: expert rename, router scale folding, and per_expert_scale passthrough. ### Testing - 5/5 new preprocess_weights tests pass - 2668/2668 full suite pass --------- Signed-off-by: Justin Chu <justinchu@microsoft.com> Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps actions/github-script from 7 to 8.
Release notes
Sourced from actions/github-script's releases.
... (truncated)
Commits
ed59741Merge pull request #653 from actions/sneha-krip/readme-for-v82dc352eBold minimum Actions Runner version in README01e118cUpdate README for Node 24 runtime requirements8b222acApply suggestion from@salmanmkcadc0eeaREADME for updating actions/github-script from v7 to v820fe497Merge pull request #637 from actions/node24e7b7f22update licenses2c81ba0Update Node.js version support to 24.xDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)