Bump actions/cache from 4 to 5 - #5
Merged
Merged
Conversation
Bumps [actions/cache](https://github.com/actions/cache) from 4 to 5. - [Release notes](https://github.com/actions/cache/releases) - [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md) - [Commits](actions/cache@v4...v5) --- updated-dependencies: - dependency-name: actions/cache dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
added
dependencies
Performance Comparison
|
justinchuby
approved these changes
Mar 20, 2026
justinchuby
added a commit
that referenced
this pull request
Apr 13, 2026
…tion, embed_scale Issue #4: Remove extra post_layernorm from _Gemma4VisionEncoderCore. HF Gemma4VisionEncoder has no post-encoder norm. The scale-free RMSNorm (embedding_pre_projection_norm) lives only in _Gemma4VisionEncoderModel as projector_norm, applied once before the projector. Issue #5: Zero padding patches and pass attention mask to vision encoder. Detect pixel_position_ids == -1 in _Gemma4VisionPatchEmbedder; zero position embeddings for those patches (matching HF _position_embeddings). Build additive attention bias [B,1,1,N] with -1e9 for padding columns and thread it through Gemma4VisionEncoderLayer -> Gemma4VisionSelfAttention -> op.Attention. After all encoder layers, zero padding patch hidden states before scaling/norm/projection (matching HF VisionPooler masked_fill). Issue #6: Replace Softmax with arithmetic normalization for MoE top-k weights. HF: top_k_weights /= top_k_weights.sum(-1, keepdim=True). We were using op.Softmax which applies exponential re-weighting. Fix: op.ReduceSum + op.Div. Issue #7: Remove np.float16 cast on embed_scale. HF uses hidden_size**0.5 as exact float32. np.float16 introduces ~0.01% rounding error on every embedding lookup. Use math.sqrt() instead. Both occurrences fixed (_Gemma4TextModel and Gemma4EmbeddingModel). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps actions/cache from 4 to 5.
Release notes
Sourced from actions/cache's releases.
... (truncated)
Changelog
Sourced from actions/cache's changelog.
... (truncated)
Commits
cdf6c1fMerge pull request #1695 from actions/Link-/prepare-5.0.3a1bee22Add review for the@actions/http-clientlicense4695763Add licensed outputdc73bb9Upgrade dependencies and address security warnings345d5c2Add 5.0.3 builds8b402f5Merge pull request #1692 from GhadimiR/main304ab5alicense for httpclient609fc19Update licensed record for cacheb22231eBuild93150cdAdd PR link to releasesDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)