Skip to content

Import/Export Libraries - #10

Closed
Kelketek wants to merge 2 commits into
content-libraries-prototypefrom
kelketek/content_library_import_export
Closed

Import/Export Libraries#10
Kelketek wants to merge 2 commits into
content-libraries-prototypefrom
kelketek/content_library_import_export

Conversation

@Kelketek

Copy link
Copy Markdown
Member

Import and Export content libraries via XML.

@bradenmacdonald
bradenmacdonald force-pushed the content-libraries-prototype branch from 3e44683 to 1c5c007 Compare November 14, 2014 05:36
@Kelketek
Kelketek force-pushed the kelketek/content_library_import_export branch 2 times, most recently from 4abb38d to 29af8df Compare November 15, 2014 23:28
@Kelketek Kelketek changed the title Import/Export Libraries (WIP) Import/Export Libraries Nov 15, 2014
@Kelketek
Kelketek force-pushed the kelketek/content_library_import_export branch 3 times, most recently from de02b8e to 7b4bb22 Compare November 16, 2014 00:38

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might make sense to factor out kind of helper method that would actually do the work so this method's only responsibility is to call helper with correct parameters, something like.

Helper might look something like

def import_courselike(request, subdir, fname, loader):
    ....

And be called something like

 course_items = import_courselike(request, subdir, "library.xml", import_library_from_xml)

BUt this might have no benefit over what we have now, so it's up to you :)

@e-kolpakov

Copy link
Copy Markdown

Looks good overall 👍

@Kelketek
Kelketek force-pushed the kelketek/content_library_import_export branch from 7b4bb22 to c520f58 Compare November 21, 2014 16:39

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Kelketek upstream reviewers asked to remove this entire "Tools" block from the very first PR, so you'll have to add it. I've saved a gist for you, though: https://gist.github.com/e-kolpakov/afc0942f781c63b4ca42.

Should go at the very bottom of <div class="wrapper wrapper-l">, just after closing </nav>, unless later PRs introduced other changes.

pomegranited added a commit that referenced this pull request Sep 11, 2018
* Updates translations for the Sign In/Registration, and incomplete profile
@bradenmacdonald
bradenmacdonald deleted the kelketek/content_library_import_export branch May 18, 2019 21:50
pomegranited pushed a commit that referenced this pull request Jul 4, 2019
This has already been patched in the upstream master branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants