Import/Export Libraries - #10
Conversation
3e44683 to
1c5c007
Compare
4abb38d to
29af8df
Compare
de02b8e to
7b4bb22
Compare
There was a problem hiding this comment.
It might make sense to factor out kind of helper method that would actually do the work so this method's only responsibility is to call helper with correct parameters, something like.
Helper might look something like
def import_courselike(request, subdir, fname, loader):
....
And be called something like
course_items = import_courselike(request, subdir, "library.xml", import_library_from_xml)
BUt this might have no benefit over what we have now, so it's up to you :)
|
Looks good overall 👍 |
7b4bb22 to
c520f58
Compare
There was a problem hiding this comment.
@Kelketek upstream reviewers asked to remove this entire "Tools" block from the very first PR, so you'll have to add it. I've saved a gist for you, though: https://gist.github.com/e-kolpakov/afc0942f781c63b4ca42.
Should go at the very bottom of <div class="wrapper wrapper-l">, just after closing </nav>, unless later PRs introduced other changes.
* Updates translations for the Sign In/Registration, and incomplete profile
This has already been patched in the upstream master branch
Import and Export content libraries via XML.