Cherry pick certificate authorization checks to Ironwood - #182
Closed
kaizoku wants to merge 3 commits into
Closed
Conversation
|
@kaizoku Your PR is failing because |
giovannicimolin
approved these changes
Jul 29, 2019
giovannicimolin
left a comment
There was a problem hiding this comment.
👍
- I tested this:
- Checked out this branch.
- Generated fake certificate for user.
- Checked that the certificate was publicly accessible ✔️
- Switched
certificates.require_loginon - Checked that the certificate page required login to be accessible, and the redirect pointed back to the correct page. ✔️
- I read through the code
- I checked for accessibility issues
- Includes documentation
⚠️
@kaizoku Thanks for the work here! Can you make these changes on the upstream PR too?
|
@josh, @giovannicimolin, is this still required? Asking because I found a sandbox for this PR on Ocim stage for this PR and was wondering if that can be archived. |
kaizoku
force-pushed
the
josh/BB-1388
branch
from
February 28, 2020 03:36
160b240 to
2724db9
Compare
Base automatically changed from
opencraft-release/ironwood.2
to
opencraft-release/ironwood.2-asu-ytp
December 22, 2020 14:30
Member
|
We're not using this branch anymore, so I'm closing the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This cherry picks an upstreamed WaffleFlag to require logins for certificate views.
This also adds the certificate status to the GeneratedCertificates admin page view.
JIRA tickets: Implements BB-1388.
Dependencies: None
Sandbox URL: https://pr20957.sandbox.opencraft.hosting/
Testing instructions:
Author notes and concerns:
Reviewers