Skip to content

[BB-3144] Backport patches from Juniper - #286

Closed
Agrendalath wants to merge 5 commits into
opencraft-release/ironwood.2from
agrendalath/bb-3144-backport-patches
Closed

[BB-3144] Backport patches from Juniper#286
Agrendalath wants to merge 5 commits into
opencraft-release/ironwood.2from
agrendalath/bb-3144-backport-patches

Conversation

@Agrendalath

@Agrendalath Agrendalath commented Oct 30, 2020

Copy link
Copy Markdown
Member

This backports #272 and #273 to Ironwood.

We had to remove the certs_login_required (introduced in #182), because this patch forces the behavior expected there.

Testing instructions

  1. Go to course settings and check that uploading a new Course Card Image works.
  2. FOR TESTING remove <%include file="_accomplishment-header.html" /> and <%include file="_accomplishment-footer.html" /> lines from edx-platform/lms/templates/certificates/accomplishment-base.html.
  3. Add "CERTIFICATES_HTML_VIEW": true, to FEATURES in ../{lms,cms}.env.json.
  4. Generate new certificate with ./manage.py lms create_fake_cert verified course-v1:edX+DemoX+Demo_Course.i
  5. Go to Advanced Settings and set "Certificates Display Behavior" to "early_no_info".
  6. Enable certificate generation configuration here.
  7. Add certificate generation course setting for course-v1:edX+DemoX+Demo_Course here.
  8. Go to Generated certificates and change the UUIDs from test to fafa7379b7f54627a15fd5b23e371102.
  9. Log out.
  10. Go to this page and confirm that the "Note Supported" message is displayed.
  11. Go to this page and confirm that you are redirected to the login page.
  12. Log in as verified@example.com.
  13. Go to this page and confirm that the "Note Supported" message is displayed.
  14. Go to this page and confirm that you can see the certificate.

@Agrendalath Agrendalath self-assigned this Oct 30, 2020
@Agrendalath
Agrendalath force-pushed the agrendalath/bb-3144-backport-patches branch from 0f17340 to 5b543ff Compare October 30, 2020 17:46
@Agrendalath
Agrendalath marked this pull request as ready for review October 30, 2020 18:03
@Agrendalath

Copy link
Copy Markdown
Member Author

Closing to handle this in #289.

@Agrendalath Agrendalath closed this Nov 5, 2020
@Agrendalath
Agrendalath deleted the agrendalath/bb-3144-backport-patches branch November 5, 2020 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants