[BB-3144] Backport patches from Juniper - #286
Closed
Agrendalath wants to merge 5 commits into
Closed
Conversation
Agrendalath
force-pushed
the
agrendalath/bb-3144-backport-patches
branch
from
October 30, 2020 17:46
0f17340 to
5b543ff
Compare
Agrendalath
marked this pull request as ready for review
October 30, 2020 18:03
Member
Author
|
Closing to handle this in #289. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This backports #272 and #273 to Ironwood.
We had to remove the
certs_login_required(introduced in #182), because this patch forces the behavior expected there.Testing instructions
<%include file="_accomplishment-header.html" />and<%include file="_accomplishment-footer.html" />lines fromedx-platform/lms/templates/certificates/accomplishment-base.html."CERTIFICATES_HTML_VIEW": true,toFEATURESin../{lms,cms}.env.json../manage.py lms create_fake_cert verified course-v1:edX+DemoX+Demo_Course.i"early_no_info".course-v1:edX+DemoX+Demo_Coursehere.testtofafa7379b7f54627a15fd5b23e371102.verified@example.com.