Skip to content

SE-2483 unhide certificates toggle ironwood - #219

Merged
samuelallan72 merged 1 commit into
opencraft-release/ironwood.2from
samuel/unhide-certificates-toggle-ironwood
Apr 17, 2020
Merged

SE-2483 unhide certificates toggle ironwood#219
samuelallan72 merged 1 commit into
opencraft-release/ironwood.2from
samuel/unhide-certificates-toggle-ironwood

Conversation

@samuelallan72

Copy link
Copy Markdown
Member

See https://github.com/edx/edx-platform/pull/23735 - this is the ironwood backport of that PR

Student-generated certificates are meant to be auto-enabled through
signal for self-paced courses, but it has been observed that this
behaviour is flaky. When this happens, we are left in a state where it
is impossible to enable student-generated certificates because the
section is hidden in the instructor dashboard.

Also by unconditionally displaying the toggle button, this allows more
flexibility for instructors. For example, it may be desirable for
student-generated certificates to be disabled for a self-paced course.

(cherry picked from commit 86acd244d964e6281f3564d14e370e5bc79c2fbb)
@samuelallan72 samuelallan72 self-assigned this Apr 16, 2020

@pomegranited pomegranited left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

  • I tested this by checking the behaviour on the client appserver where this change is deployed.
  • I checked the code against the original https://github.com/edx/edx-platform/pull/23735
  • I made sure any change in configuration variables is reflected in the corresponding
    client's configuration-secure repository.
    N/A

@samuelallan72
samuelallan72 merged commit b476991 into opencraft-release/ironwood.2 Apr 17, 2020
@samuelallan72
samuelallan72 deleted the samuel/unhide-certificates-toggle-ironwood branch April 17, 2020 03:04
farhaanbukhsh pushed a commit that referenced this pull request Feb 11, 2021
…for-notes-needs-to-handle-tags-better

Fix XSS vector for a11y text attached to notes editor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants