Skip to content

FAL-867 Revert "Unhide student-generated certificates toggle" - #356

Merged
samuelallan72 merged 1 commit into
opencraft-release/koa.3from
samuel/revert-certificates-toggle
Jun 5, 2021
Merged

FAL-867 Revert "Unhide student-generated certificates toggle"#356
samuelallan72 merged 1 commit into
opencraft-release/koa.3from
samuel/revert-certificates-toggle

Conversation

@samuelallan72

@samuelallan72 samuelallan72 commented Jun 3, 2021

Copy link
Copy Markdown
Member

This reverts commit 8910ccf ( #219 ).

Our clients are no longer using this feature, and edX won't accept this
upstream as-is currently. See https://github.com/edx/edx-platform/pull/23735 for more information.

Reverting to reduce code drift from upstream.

Test instructions:

Reviewers:

This reverts commit 8910ccf.

Our clients are no longer using this feature, and edX won't accept this
upstream as-is currently.  See https://github.com/edx/edx-platform/pull/23735 for more information.

Reverting to reduce code drift from upstream.
@samuelallan72 samuelallan72 self-assigned this Jun 3, 2021

@pomegranited pomegranited left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

  • I tested this on pr356.sandbox.stage.opencraft.hosting
  • I checked the code against the original #219
  • I made sure any change in configuration variables is reflected in the corresponding client's configuration-secure repository N/A

@samuelallan72
samuelallan72 merged commit 4b7291d into opencraft-release/koa.3 Jun 5, 2021
@samuelallan72
samuelallan72 deleted the samuel/revert-certificates-toggle branch June 5, 2021 00:06
dliberat pushed a commit that referenced this pull request Jul 8, 2021
…ggle

FAL-867 Revert "Unhide student-generated certificates toggle"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants