[SE-5135] Update HTML templates to the v2 counterparts. - #453
Merged
keithgg merged 2 commits intoJan 25, 2022
Merged
Conversation
Author
|
@pkulkark I deleted the templates that weren't mentioned in the v2 section. Should I have kept them? |
pkulkark
requested changes
Jan 24, 2022
| metadata: | ||
| display_name: Downloads | ||
| data: | | ||
| <div class="div-info"><img class="icon-image" src="/static/!downloads.png" alt="" /> |
Member
There was a problem hiding this comment.
Nit: I'm guessing the "!" in the src field got in there by mistake but it's preventing the image from loading currectly. So please correct it.
| <p>Add text and links to your optional readings here.</p> | ||
| </div> | ||
| </div> No newline at end of file | ||
| display_name: Optional Reading |
Member
There was a problem hiding this comment.
Nit: The display name also need to be updated to "Optional Reading or Optional Resources".
This was referenced Mar 23, 2022
This was referenced Apr 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
For Studio users updates templates to the v2 counterparts.
Supporting information
Testing instructions
Deadline
21 Jan 2022.