(redo) feat: added new setting CUSTOM_RESOURCE_TEMPLATES_DIRECTORY - #31117
Closed
keithgg wants to merge 1 commit into
Closed
(redo) feat: added new setting CUSTOM_RESOURCE_TEMPLATES_DIRECTORY#31117keithgg wants to merge 1 commit into
keithgg wants to merge 1 commit into
Conversation
|
Thanks for the pull request, @keithgg! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
This setting allows loading of Resource Templates from outside the edx-platform codebase. Operators will be able to add their own custom resource templates without needing to fork the codebase. (cherry picked from commit ed81774)
keithgg
force-pushed
the
keith/bb_5885_new_maple_backport
branch
from
October 6, 2022 09:51
b96da20 to
e03eea7
Compare
|
@keithgg Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a redo of #30759 which itself is a backport of #30108 to maple.master. Re-using the description below.
Description
At Opencraft, we have clients that want to be able to add custom HTML templates that show up while creating course components in Studio.
Currently, there's no way to achieve this besides forking
edx-platformand adding theyamlfiles tocommon/lib/xmodule/xmodule/templates/This PR allows operators to set a custom directory where templates can be additionally loaded from.
settings.CUSTOM_RESOURCE_TEMPLATES_DIRECTORYexists.yamlfiles with the same logic as in thexmodule/templatesdirectory.Supporting information
Testing instructions
settings.CUSTOM_RESOURCE_TEMPLATES_DIRECTORYto a valid path.htmldirectory.common/lib/xmodule/xmodule/templates/htmlto the above directory with a different filename.Deadline
"None"
Other
Settings