WIP - Content libraries settings overrides - #6
Closed
bradenmacdonald wants to merge 2 commits into
Closed
Conversation
There was a problem hiding this comment.
It's not quite identical to the replacement. I believe you've tried refactoring to pieces of code into a lambda (which is good), but missed the fact that they are slightly different (which is a problem) :) Namely class_ != self.load_block_type(block_key.type)
Member
Author
There was a problem hiding this comment.
Good eye! It was actually a deliberate change, as it seems as far as I can tell that class_ == self.load_block_type(block_key.type)
bradenmacdonald
force-pushed
the
content-libraries-prototype
branch
4 times, most recently
from
November 3, 2014 21:39
773624e to
8cb9bb4
Compare
bradenmacdonald
force-pushed
the
content-libraries-settings-overrides
branch
from
November 4, 2014 08:54
3d9fc0d to
7cb2c45
Compare
bradenmacdonald
force-pushed
the
content-libraries-prototype
branch
from
November 4, 2014 22:52
cbe44a0 to
d9c583b
Compare
bradenmacdonald
force-pushed
the
content-libraries-settings-overrides
branch
from
November 5, 2014 03:52
7cb2c45 to
5c988b2
Compare
bradenmacdonald
force-pushed
the
content-libraries-settings-overrides
branch
from
November 6, 2014 20:44
5c988b2 to
2879d20
Compare
bradenmacdonald
force-pushed
the
content-libraries-prototype
branch
from
November 14, 2014 05:36
3e44683 to
1c5c007
Compare
bradenmacdonald
force-pushed
the
content-libraries-settings-overrides
branch
from
November 14, 2014 06:00
2879d20 to
e1ff935
Compare
Member
Author
|
Replaced by #25. |
mtyaka
pushed a commit
that referenced
this pull request
Feb 10, 2016
mtyaka
pushed a commit
that referenced
this pull request
Feb 10, 2016
…dback-update-7 Hash Update #6: Diagnostic-Feedback [Bug Fixes]
pomegranited
pushed a commit
that referenced
this pull request
Jun 18, 2019
Fix ccx visibility on catalog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes split mongo behaviour so that XBlock fields with Scope.settings can have their
defaultoverriden in the definition. This adds a newdefaultsobject to definitions in split mongo.Notes:
persist_xblock_dagand_persist_subdagmethods? They are only used in a couple tests as far as I can tell, yet they are not in atestsmodule... I didn't update them to be compatible with this feature.One potential problem is that the definitions are often lazy-loaded, so in order to check if the default is set or not, we sometimes now need to load the definition when in the past it wasn't loaded. This was causing some platform tests to fail because more mongo calls are used than before. Possible solutions:
has_defaultsflag on the structure - this is what I have done for now