Content libraries permissions - #8
Closed
bradenmacdonald wants to merge 2 commits into
Closed
Conversation
There was a problem hiding this comment.
Could be written as OrgLibraryUserRole(org=course_key.org).has_user(user) or LibraryUserRole(course_key.for_branch(None)).has_user(user)
|
Looks good, the only thing I'm concerned about is the fact hat there are some changes that might conflict with paging effort, but that's not something you could fix until you have my paging code :). |
bradenmacdonald
force-pushed
the
content-libraries-permissions
branch
from
November 11, 2014 20:34
5fb5312 to
acbaddb
Compare
Admin ("Instructor") - Can edit and assign permissions to other users
Normal ("Staff") - Can edit
User - Can view the library and use content from it but cannot edit it or its blocks.
bradenmacdonald
force-pushed
the
content-libraries-prototype
branch
from
November 14, 2014 05:36
3e44683 to
1c5c007
Compare
bradenmacdonald
force-pushed
the
content-libraries-permissions
branch
from
November 14, 2014 05:36
acbaddb to
9edecd1
Compare
Member
Author
|
Closing. The latest code for library permissions is in content_libraries/5-permissions and is waiting for upstream PRs to be merged before we can open a new upstream PR to merge it into the |
itsjeyd
pushed a commit
that referenced
this pull request
Nov 30, 2016
Adds update_anonymous_user_ids management command
pomegranited
pushed a commit
that referenced
this pull request
Jun 26, 2019
Fix username hints for SSO
DanielVZ96
pushed a commit
that referenced
this pull request
Jan 31, 2024
This custom image includes the elasticsearch-head plugin Fixes #8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request implements more fine-grained permissions for content libraries.
There are three roles that users can have:
No UI has yet been implemented for assigning these roles to users, but you can see the tests for how to do it from code. You can also test it out by assigning roles manually - just ensure the django admin site is enabled, then go to http://localhost:8001/admin/student/courseaccessrole/ and create entries with role of
library_userorstafforinstructorandcourseequal to the library's key.Note: The permissions are currently not checked when the
refresh_childrenmethod ofLibraryContentModuledoes its thing. This will be implemented after theScope.settingsstuff is figured out (see #6), since it involved re-writingrefresh_children.