Skip to content

MCKIN-12768 Feedback icons changed to button for averall assessment case #257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
giovannicimolin merged 32 commits into from
Jan 24, 2020
Merged

MCKIN-12768 Feedback icons changed to button for averall assessment case #257

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
1eacbf0
Merge pull request #1 from open-craft/master
musmanmalik Jan 3, 2020
3e3166a
span changed to button for MCQs and Multi-rating questions to make th…
musmanmalik Jan 6, 2020
89c585f
version changed
musmanmalik Jan 6, 2020
dd3b4f8
Accessibility: Overall checkmark made accessible via keyboard
musmanmalik Jan 9, 2020
ba7cce5
version updated
musmanmalik Jan 9, 2020
b2b96e2
Merge branch 'master' into usman/MCKIN-12768
musmanmalik Jan 13, 2020
a7215aa
Merge branch 'master' into usman/MCKIN-12287
musmanmalik Jan 13, 2020
9142dd0
style fix for step-overall-checkmark
musmanmalik Jan 15, 2020
22e3fe1
padding added
musmanmalik Jan 16, 2020
8ba4a72
padding removed
musmanmalik Jan 17, 2020
194394c
shadow removed
musmanmalik Jan 21, 2020
4c1dc83
outline removed
musmanmalik Jan 21, 2020
a29dc6c
shadow removed
musmanmalik Jan 21, 2020
f17f4d9
outline added
musmanmalik Jan 22, 2020
f8a2daa
outline removed
musmanmalik Jan 22, 2020
83824ac
Style refinement
musmanmalik Jan 22, 2020
9c4d7fb
style refined
musmanmalik Jan 22, 2020
c75913e
removed unnecessary code
musmanmalik Jan 22, 2020
ad3f883
position issue fixed
musmanmalik Jan 23, 2020
909e0e0
ratingblock issue fixed
musmanmalik Jan 23, 2020
fe6c469
Tip positioning have been fixed.
musmanmalik Jan 24, 2020
a67015a
Tip positioning have been fixed.
musmanmalik Jan 24, 2020
9cb2eb6
Accessibility: Overall checkmark made accessible via keyboard
musmanmalik Jan 9, 2020
d8a49f2
style fix for step-overall-checkmark
musmanmalik Jan 15, 2020
aea56ef
padding added
musmanmalik Jan 16, 2020
5b9011b
padding removed
musmanmalik Jan 17, 2020
bfcb5b0
shadow removed
musmanmalik Jan 21, 2020
b5fd90f
outline removed
musmanmalik Jan 21, 2020
db6c05e
outline removed
musmanmalik Jan 22, 2020
7d178f8
version updated
musmanmalik Jan 24, 2020
f086fe8
Merge remote-tracking branch 'origin/usman/MCKIN-12768' into usman/MC…
musmanmalik Jan 24, 2020
b7d987e
Merge branch 'master' into usman/MCKIN-12768
musmanmalik Jan 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions problem_builder/public/css/questionnaire.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,3 +154,10 @@
right: auto;
left: 3px;
}

.assessment-question-block .submit button.step-overall-checkmark {
border: 0;
padding: 0;
background: none;
box-shadow: none !important;
}
4 changes: 2 additions & 2 deletions problem_builder/templates/html/mentoring_with_steps.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,9 @@ <h3>{{ title }}</h3>
{% endfor %}

<div class="submit">
<span class="step-overall-checkmark fa icon-2x fa-fw" aria-label=""
<button class="step-overall-checkmark fa icon-2x fa-fw" aria-label=""
Comment thread
giovannicimolin marked this conversation as resolved.
data-label_correct="{% trans "Correct" %}" data-label_incorrect="{% trans "Incorrect" %}"
data-label_partial="{% trans "Partially correct" %}"></span>
data-label_partial="{% trans "Partially correct" %}"></button>
<input type="button" class="input-main" value="{% trans "Submit" %}" disabled="disabled" />
<input type="button" class="input-next" value="{% trans "Next Step" %}" disabled="disabled" />
<input type="button" class="input-review" value="{% trans "Review grade" %}" disabled="disabled" />
Expand Down
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@

# Constants #########################################################

VERSION = '3.4.8'
VERSION = '3.4.9'

# Functions #########################################################

Expand Down