MCKIN-12768 Feedback icons changed to button for averall assessment case - #257
Merged
giovannicimolin merged 32 commits intoJan 24, 2020
Merged
Conversation
Member
|
@musmanmalik Please ping only me on such pull request since I am responsible for prioritising and assigning these PRs. |
Contributor
Author
|
@xitij2000 Okay sure |
giovannicimolin
suggested changes
Jan 14, 2020
giovannicimolin
left a comment
giovannicimolin
left a comment
Contributor
There was a problem hiding this comment.
@musmanmalik I've left a comment on the PR.
Can you reply, make the necessary changes and let me know if you have any concerns about the solution I've proposed?
Member
|
@musmanmalik, as #256 PR is now merged, could you please rebase this PR on |
…KIN-12768 # Conflicts: # setup.py
Contributor
Author
|
@Agrendalath @giovannicimolin Please merge this and create release tag |
giovannicimolin
approved these changes
Jan 24, 2020
giovannicimolin
left a comment
giovannicimolin
left a comment
Contributor
There was a problem hiding this comment.
👍
- I tested this:
- Installed this branch on a
masterdevstack. - Create a new course and added a step-builder with MCQ in mentoring step.
- Checked that the feedback icon is selectable and readable by the screen reader ✔️
- I read through the code
- I checked for accessibility issues: fixes an accessibility issue.
-
Includes documentationNA
@musmanmalik Thanks for this improvement. I'll merge the PR and create a new version tag.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are working on accessibility. This is also one the the reported. This fix has been done for MRQs already and fro MCQs and multi rating questions in progress. In this pull request this is fixed for assessment checkmark.
At a basic level, all custom controls within a web application should provide identifying information about the component. This includes a name, type (role) and may contain state, value, and description information. When custom elements do not expose identifying information, users of assistive technology may not be able to identify and interact with the element. For example, without knowing the role or state of an element, the user of a screen reader may not know what actions can be performed on an element even if the element exposes a textual name. Without a proper role, assistive technology interactions that rely on roles being identified may not become available to the user.
The best approach is to use the element and appropriate aria attributes to indicate all the required information. This will make the icons keyboard focusable by default.
@xitij2000 @Agrendalath @lgp171188 Please review this pull request.