MCKIN-19254: fix js translations for answer block - #286
Merged
taniwha merged 1 commit intoJun 17, 2020
Conversation
Contributor
Author
|
@xitij2000 please review this when you have sometime |
taniwha
reviewed
Jun 16, 2020
taniwha
left a comment
taniwha
left a comment
There was a problem hiding this comment.
👍
- I tested this: (describe what you tested)
- I read through the code
- [ ] I checked for accessibility issues
- [ ] Includes documentation
- [ ] I made sure any change in configuration variables is reflected in the corresponding client'sconfiguration-securerepository.
Contributor
Author
|
@taniwha thank you for the review, could you also merge it and create release tag? |
Member
|
@msaqib52 Please also create an equivalent PR against the master branch. Unless a PR fixes a bug that is specific to v3 and not v4, all PRs should target both releases. |
Contributor
Author
|
@xitij2000 have created this PR for v4 #287 |
|
@msaqib52 The merge and release tag (v3.4.19) for this PR were already done, but I'll do the master-PR too. |
|
or, I thought I had, I'll fix |
taniwha
approved these changes
Jun 17, 2020
|
@msaqib52 my appologies |
Contributor
Author
|
Thank you @taniwha |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Answer block is not loading js translations due to which following string is not getting translated, This PR includes js translations in answer block response.
