Skip to content

fix js translations for answer block - #287

Merged
xitij2000 merged 1 commit into
open-craft:masterfrom
msaqib52:master
Jun 23, 2020
Merged

fix js translations for answer block#287
xitij2000 merged 1 commit into
open-craft:masterfrom
msaqib52:master

Conversation

@msaqib52

Copy link
Copy Markdown
Contributor

No description provided.

@taniwha

taniwha commented Jun 17, 2020

Copy link
Copy Markdown

@msaqib52 @xitij2000 Despite this being the same patch (minus version number) as for v3, I am unable to verify that it works. I have checked eo as well as ko-kr, both show untranslated English for that field. The v3 branch works well.

@xitij2000 xitij2000 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

  • I tested this: tested on master devstack.
  • I read through the code

@xitij2000
xitij2000 merged commit e4ffb61 into open-craft:master Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants