Skip to content

MCKIN-22514 rounding off correctly - #296

Merged
aayushagrawal9 merged 2 commits into
open-craft:masterfrom
mudassir-hafeez:MCKIN-22514
Aug 26, 2020
Merged

MCKIN-22514 rounding off correctly#296
aayushagrawal9 merged 2 commits into
open-craft:masterfrom
mudassir-hafeez:MCKIN-22514

Conversation

@mudassir-hafeez

@mudassir-hafeez mudassir-hafeez commented Aug 24, 2020

Copy link
Copy Markdown
Contributor

Jira ticket https://edx-wiki.atlassian.net/browse/MCKIN-22514

this PR keeps up to date master for #297

There is an endpoint that was missed in #267 which needs to be addressed.

@xitij2000

Copy link
Copy Markdown
Member

@mudassir-hafeez I think solutions still uses version 3 so you will also need a PR against the v3 branch.

@aayushagrawal9 aayushagrawal9 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mudassir-hafeez can you please explain the following change:

Comment thread setup.py Outdated
# Constants #########################################################

VERSION = '4.0.6'
VERSION = '3.4.23'

@aayushagrawal9 aayushagrawal9 Aug 25, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this downgraded?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aayushagra thank you for taking my attention towards it. Actually, if you see releases, we were using two different versions of releases. one is for Ironwood Open edX releases and other is for normal releases. After Ironwood upgrade, releases should be as they were before. @xitij2000 can you please comment on that what should be the right release version from now.

@mudassir-hafeez

Copy link
Copy Markdown
Contributor Author

Oh got it, we are using 4 series of releases for master and 3 series against the v3 branch

@mudassir-hafeez

Copy link
Copy Markdown
Contributor Author

@aayushagra I have updated the version accordingly. can you please review it once more? thanks

@aayushagrawal9

aayushagrawal9 commented Aug 26, 2020

Copy link
Copy Markdown
Contributor

👍

  • I tested this: Tested that the code works as intended and tests pass
  • I read through the code
  • I checked for accessibility issues
  • Includes documentation
  • I made sure any change in configuration variables is reflected in the corresponding client's configuration-secure repository.

@aayushagrawal9
aayushagrawal9 merged commit 94fcaed into open-craft:master Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants