MCKIN-22514 round off correctly for v3 - #297
Merged
aayushagrawal9 merged 1 commit intoAug 25, 2020
Merged
Conversation
Contributor
Author
|
@xitij2000 here is the PR for v3. Can you please review it? |
Contributor
Author
|
Thank you @aayushagra for reviewing this PR. we have the same #296 for the master branch. Can you please review that too? |
Contributor
|
👍
|
Contributor
Author
|
@aayushagra It seems like you didn't create the release tag version as it should be. I think it would be a typo and should be |
Member
|
@mudassir-hafeez I've updated the tags. We've been a bit inconsistent about this at times. |
Contributor
Author
|
@xitij2000 thank you for updating the tags. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira ticket https://edx-wiki.atlassian.net/browse/MCKIN-22514
There is an endpoint that was missed in #267 which needs to be addressed.