Skip to content

Ensure that time conversion for 0 returns nil timestamps or Time where IsZero returns true#1550

Merged
bogdandrutu merged 1 commit intoopen-telemetry:masterfrom
bogdandrutu:zerotimes
Aug 14, 2020
Merged

Ensure that time conversion for 0 returns nil timestamps or Time where IsZero returns true#1550
bogdandrutu merged 1 commit intoopen-telemetry:masterfrom
bogdandrutu:zerotimes

Conversation

@bogdandrutu
Copy link
Copy Markdown
Member

No description provided.

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@codecov
Copy link
Copy Markdown

codecov bot commented Aug 14, 2020

Codecov Report

Merging #1550 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1550      +/-   ##
==========================================
+ Coverage   91.45%   91.46%   +0.01%     
==========================================
  Files         248      248              
  Lines       17242    17244       +2     
==========================================
+ Hits        15768    15772       +4     
+ Misses       1063     1062       -1     
+ Partials      411      410       -1     
Impacted Files Coverage Δ
internal/internal.go 90.47% <100.00%> (+11.52%) ⬆️
translator/internaldata/resource_to_oc.go 87.50% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 442c6df...9697cc4. Read the comment docs.

@bogdandrutu bogdandrutu changed the title Ensure that time conversion for 0 returns 0 timestamps Ensure that time conversion for 0 returns nil timestamps or Time where IsZero returns true Aug 14, 2020
@bogdandrutu bogdandrutu merged commit dba178b into open-telemetry:master Aug 14, 2020
@bogdandrutu bogdandrutu deleted the zerotimes branch August 14, 2020 17:31
hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this pull request Apr 27, 2023
Bumps golang from 1.18.1-stretch to 1.18.2-stretch.

---
updated-dependencies:
- dependency-name: golang
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants