Cleanup usage of TimestampUnixNanos and its API#2549
Merged
bogdandrutu merged 1 commit intoopen-telemetry:mainfrom Feb 25, 2021
Merged
Cleanup usage of TimestampUnixNanos and its API#2549bogdandrutu merged 1 commit intoopen-telemetry:mainfrom
bogdandrutu merged 1 commit intoopen-telemetry:mainfrom
Conversation
bogdandrutu
force-pushed
the
timestamp
branch
from
c231b80 to
f9dea87
Compare
Codecov Report
@@ Coverage Diff @@
## main #2549 +/- ##
==========================================
- Coverage 91.69% 91.68% -0.01%
==========================================
Files 266 266
Lines 15111 15101 -10
==========================================
- Hits 13856 13846 -10
Misses 871 871
Partials 384 384
Continue to review full report at Codecov.
|
bogdandrutu
force-pushed
the
timestamp
branch
from
f9dea87 to
f80a3c6
Compare
Member
|
Looks good, except maybe change of behavior for zero time. We had a bug which was fixed by this. I don't remember what exactly, maybe try digging using git blame to see when was it introduced. |
Member
Author
|
Even if we fixed other bug, we did that by adding a new bug because IsZero on the time package means year 1 not 1970 |
Member
Author
|
@tigrannajaryan I think it was a simple bug added by myself #1550 |
tigrannajaryan
approved these changes
Feb 25, 2021
Updates open-telemetry#2488 Important Changes: * Rename pdata.TimestampUnixNanos to pdata.Timestamp * Remove pdata.TimestampUnixNanos and helpers, move them of the pdata.Timestamp type. * Fix bug around IsZero, this function should return true if the time is January 1, year 1, 00:00:00 UTC not epoch. Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu
force-pushed
the
timestamp
branch
from
f80a3c6 to
e9a4c2a
Compare
This was referenced Mar 11, 2021
This was referenced Mar 15, 2021
Troels51
pushed a commit
to Troels51/opentelemetry-collector
that referenced
this pull request
Jul 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates #2488
Important Changes: