Unset GMOCK_LIB before find_library to force lookup#726
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #726 +/- ##
=======================================
Coverage 94.76% 94.76%
=======================================
Files 217 217
Lines 9929 9929
=======================================
Hits 9409 9409
Misses 520 520 |
lalitb
approved these changes
May 5, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
find_libraryis used to get the path of gmock, and build type (CMAKE_BUILD_TYPE) is checked to link to either gmockd.lib for debug build or gmock.lib for others.The problem is that
find_librarystores the found library in cache variable which will NOT be re-checked for the CMake re-run, so if the re-run changes build type, it will link to the previous gmock, which causes runtime exception, as the OTLP test and gmock then run with 2 different flavors of CRT library, and trigger exception when passing C++ types around, such asstd::string.For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes