Skip to content

Unset GMOCK_LIB before find_library to force lookup #726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lalitb merged 2 commits into from
May 5, 2021
Merged

Unset GMOCK_LIB before find_library to force lookup #726

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f48969e
Unset GMOCK_LIB before find_library to force lookup
ThomsonTan May 5, 2021
a9ff04d
Merge branch 'main' into UnsetGMock
lalitb May 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions exporters/otlp/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,12 @@ if(BUILD_TESTING)
if(MSVC)
add_definitions(-DGTEST_LINKED_AS_SHARED_LIBRARY=1)
endif()
if(GMOCK_LIB)
# unset GMOCK_LIB to force find_library to redo the lookup, as the cached
# entry could cause linking to incorrect flavor of gmock and leading to
# runtime error.
unset(GMOCK_LIB CACHE)
endif()
if(MSVC AND CMAKE_BUILD_TYPE STREQUAL "Debug")
find_library(GMOCK_LIB gmockd PATH_SUFFIXES lib)
else()
Expand Down