TracerProvider ForceFlush() Error Fix

[sawamurataxman]

Previously upon a SpanProcessor's ForceFlush returning an error, it would return that error and not attempt to flush subsequent SpanProcessors. Now when an error is encountered, it will Join the new error with the existing errors and continue iterating through the SpanProcessors and return the consolidated error at the end of iteration. This is in line with the workflow found in LoggerProvider's ForceFlush.

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: pellared / name: Robert Pająk (86311aa)

[dashpole]

lgtm. Can you add a test?

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.6%. Comparing base (78f9904) to head (86311aa).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##            main   #7856     +/-   ##
=======================================
- Coverage   81.6%   81.6%   -0.1%     
=======================================
  Files        304     304             
  Lines      23389   23389             
=======================================
- Hits       19096   19095      -1     
- Misses      3906    3907      +1     
  Partials     387     387             

Files with missing lines	Coverage Δ
sdk/trace/provider.go	86.7% <100.0%> (+0.9%)	⬆️

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[sawamurataxman]

Sorry for pinging while checks are failing - working on it.

[sawamurataxman]

Anything else I can/should do for this to get it merged?

[seh]

This creates a singly-linked list of errors.joinErrors, each of them but the first containing only two errors, one of which is the errors.joinError from the previous failure in calling ForceFlush.

What I expect that you intended to create here was a flat sequence of errors. Sketching:

errs := make([]error, 0, len(spss))
for _, sps := range spss {
  // ...
  if err := sps.sp.ForceFlush(ctx); err != nil {
    errs = append(errs, err)
  }
}
return errors.Join(errs...)