Skip to content

attribute: add TestNotEquivalence and equality operator tests#7979

Merged
pellared merged 5 commits intoopen-telemetry:mainfrom
pellared:attr-tests
Mar 3, 2026
Merged

attribute: add TestNotEquivalence and equality operator tests#7979
pellared merged 5 commits intoopen-telemetry:mainfrom
pellared:attr-tests

Conversation

@pellared
Copy link
Copy Markdown
Member

@pellared pellared commented Mar 2, 2026

Related to #7970

Add missing unit tests.

@pellared pellared added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Mar 2, 2026
@pellared pellared requested a review from Copilot March 2, 2026 12:50
@pellared pellared marked this pull request as ready for review March 2, 2026 12:51
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.7%. Comparing base (a866564) to head (f141b10).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #7979   +/-   ##
=====================================
  Coverage   81.7%   81.7%           
=====================================
  Files        304     304           
  Lines      23342   23342           
=====================================
+ Hits       19087   19089    +2     
+ Misses      3866    3864    -2     
  Partials     389     389           

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds missing unit test coverage around attribute equivalence behavior, including direct == comparisons, in support of the ongoing work to support new attribute types (Issue #7970).

Changes:

  • Extend TestEquivalence with direct equality-operator (==) checks for attribute.KeyValue.
  • Add TestNotEquivalence to validate non-equivalent KeyValue pairs across Distinct, Set, and == comparisons.
  • Remove a redundant assertion message in the existing equivalence test.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@pellared pellared merged commit 4ba8200 into open-telemetry:main Mar 3, 2026
31 checks passed
@pellared pellared added this to the v1.42.0 milestone Mar 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Skip Changelog PRs that do not require a CHANGELOG.md entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants