attribute: add TestNotEquivalence and equality operator tests#7979
Merged
pellared merged 5 commits intoopen-telemetry:mainfrom Mar 3, 2026
Merged
attribute: add TestNotEquivalence and equality operator tests#7979pellared merged 5 commits intoopen-telemetry:mainfrom
pellared merged 5 commits intoopen-telemetry:mainfrom
Conversation
pellared
commented
Mar 2, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7979 +/- ##
=====================================
Coverage 81.7% 81.7%
=====================================
Files 304 304
Lines 23342 23342
=====================================
+ Hits 19087 19089 +2
+ Misses 3866 3864 -2
Partials 389 389 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
Adds missing unit test coverage around attribute equivalence behavior, including direct == comparisons, in support of the ongoing work to support new attribute types (Issue #7970).
Changes:
- Extend
TestEquivalencewith direct equality-operator (==) checks forattribute.KeyValue. - Add
TestNotEquivalenceto validate non-equivalentKeyValuepairs acrossDistinct,Set, and==comparisons. - Remove a redundant assertion message in the existing equivalence test.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
dmathieu
approved these changes
Mar 2, 2026
dashpole
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #7970
Add missing unit tests.