feat: remove hardcoded version of go in GitHub Actions workflows#1839
Merged
Conversation
tylerbenson
approved these changes
Jun 3, 2025
pragmaticivan
approved these changes
Jun 3, 2025
tylerbenson
added
the
github_actions
This was referenced Jun 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
This PR fixes the first todo of #1838
It uses the documented
go-version-fileinstead of an hardcoded value (doc: https://github.com/actions/setup-go?tab=readme-ov-file#getting-go-version-from-the-gomod-file)Even if the go version is printed out in the output of
actions/setup-goI think it's useful to print it in the build target (see Makefile) for potential debugging purpose, totally fine to remove it if needed.Test
Tested on my fork ✅
actions/setup-gomake build