feat: go mod auto version update#1848
Conversation
| pull-requests: write | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: 030/gomod-go-version-updater-action@7de28fa4093a877ba8924f7901e6c7b6e5dd3954 # v0.3.3 No newline at end of file |
There was a problem hiding this comment.
Is this being used anywhere else within otel?
There was a problem hiding this comment.
@tylerbenson no I could not find other usage. Maybe we can pioneer this and influence other go repos if this is working well for us?
if you look at the code, it's a very simple action: https://github.com/030/gomod-go-version-updater-action/blob/main/main.py
There was a problem hiding this comment.
@trask @carlosalberto @jaronoff97 @codeboten WDYT? Does this need further review or good to go?
There was a problem hiding this comment.
from a security perspective, I personally avoid github actions that are not widely used, since it's one more attack vector you have to worry about
that said, I don't think we have any official guidance for OpenTelemetry repositories, and I suspect that we would first focus on limiting the github token permissions, since that's typically the easier win:
An action can access the GITHUB_TOKEN through the github.token context even if the workflow does not explicitly pass the GITHUB_TOKEN to the action. As a good security practice, you should always make sure that actions only have the minimum access they require by limiting the permissions granted to the GITHUB_TOKEN. For more information, see Permissions for the GITHUB_TOKEN.
In this particular case though, have you checked if Renovate will automatically update this for you? The majority of OpenTelemetry repos are on Renovate now, and I believe the Go repos were early Renovate adopters.
cc @open-telemetry/sig-security-approvers @open-telemetry/go-approvers
|
oops sorry I removed the branch 😶🌫️ , will reopen |
This is a follow-up PR on this: #1839 to complete this: #1838
I've tried it on my fork and the PR with a bump is indeed created see the example here: maxday#7
Quick notes:
Let me know!
Max