Use gh-pages to save performance benchmarks results#1469
Merged
codeboten merged 1 commit intoopen-telemetry:masterfrom Dec 13, 2020
Merged
Use gh-pages to save performance benchmarks results#1469codeboten merged 1 commit intoopen-telemetry:masterfrom
codeboten merged 1 commit intoopen-telemetry:masterfrom
Conversation
NathanielRN
requested review from
a team,
codeboten and
ocelotl
and removed request for
a team
aabmass
approved these changes
Dec 11, 2020
aabmass
reviewed
Dec 11, 2020
NathanielRN
force-pushed
the
benchmarks-on-gh-pages
branch
from
01ca210 to
975a4d1
Compare
NathanielRN
force-pushed
the
benchmarks-on-gh-pages
branch
from
975a4d1 to
67c4e4d
Compare
codeboten
approved these changes
Dec 13, 2020
3 tasks
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As a follow up to #1443 we found out that the GitHub action will fetch the branch even if it on that branch which produces an error.
This PR goes back to using
gh-pagesand adds a link in the ReadTheDocs directory to point to the benchmarks graphs which will live on thegh-pagesbranch.This is also a good idea to reduce the noise on the
masterbranch.This will fix the current Core Repo Tests.
Type of change
How Has This Been Tested?
See my example repo which uses
gh-pagescorrectly to publish to https://nathanielrn.github.io/github-benchmarks-example/benchmarks/index.htmlDoes This PR Require a Contrib Repo Change?
Checklist: