Fix Benchmarks grouping name#1473
Merged
lzchen merged 1 commit intoopen-telemetry:masterfrom Dec 14, 2020
Merged
Conversation
NathanielRN
requested review from
a team,
ocelotl and
owais
and removed request for
a team
codeboten
approved these changes
Dec 14, 2020
lzchen
approved these changes
Dec 14, 2020
3 tasks
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow up to #1469. We had the incorrect name for the package. This means the benchmarks will be recorded without package name in the table title. This is important for grouping of similar benchmarks across commits.
Type of change
How Has This Been Tested?
N/A
Does This PR Require a Contrib Repo Change?
Checklist:
- [ ] Changelogs have been updated- [ ] Unit tests have been added- [ ] Documentation has been updated