Change AttributeValue sequences from optional to nonoptional#1855
Merged
codeboten merged 7 commits intoopen-telemetry:mainfrom May 21, 2021
Merged
Change AttributeValue sequences from optional to nonoptional#1855codeboten merged 7 commits intoopen-telemetry:mainfrom
codeboten merged 7 commits intoopen-telemetry:mainfrom
Conversation
New changes will ensure that mypy users will be alerted when trying to add None to an AttributeValue array, without altering the current code that may continue to accept None.
eddyleelin
requested review from
a team,
aabmass and
lzchen
and removed request for
a team
srikanthccv
approved these changes
May 19, 2021
lzchen
reviewed
May 19, 2021
codeboten
reviewed
May 19, 2021
Contributor
codeboten
left a comment
codeboten
left a comment
There was a problem hiding this comment.
Change looks good, please update the branch and add a Changed header to the changelog.
lzchen
approved these changes
May 20, 2021
codeboten
approved these changes
May 21, 2021
Contributor
codeboten
left a comment
codeboten
left a comment
There was a problem hiding this comment.
Please resolve the changelog conflict and we can get this PR merged, thanks!
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Per attribute specifications,
Nonevalues should be discouraged in AttributeValues, but Python cannot actually preventNonevalues. Thus, the new changes will ensure that mypy users will be alerted when trying to add None to an AttributeValue array, without altering the current code that may continue to accept None.Fixes issue #1738
Type of change
This is a simple bug fix that will help mypy users conform with specifications.
How Has This Been Tested?
Running the following test suites returned a clean report:
Does This PR Require a Contrib Repo Change?
Checklist: