Skip to content

Change AttributeValue sequences from optional to nonoptional #1855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
codeboten merged 7 commits into from
May 21, 2021
Merged

Change AttributeValue sequences from optional to nonoptional #1855

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f4ed451
Change AttributeValue sequences from optional to nonoptional
eddyleelin May 14, 2021
56a948e
Added entry to changelog
eddyleelin May 14, 2021
31efa2d
Moved change log entry to unreleased section and updated link
eddyleelin May 19, 2021
23d6c4a
Merge branch 'main' into update-typechecking-array
eddyleelin May 20, 2021
0274a17
Added "Changed" header to change log
eddyleelin May 20, 2021
67e76e1
Merge branch 'update-typechecking-array' of https://github.com/open-o…
eddyleelin May 20, 2021
086e7e5
Merge branch 'main' into update-typechecking-array
eddyleelin May 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
([#1809])(https://github.com/open-telemetry/opentelemetry-python/pull/1809)
- Fixed sequence values in OTLP exporter not translating
([#1818](https://github.com/open-telemetry/opentelemetry-python/pull/1818))
- Changed AttributeValue sequences to warn mypy users on adding None values to array
(TBD)

### Removed
- Moved `opentelemetry-instrumentation` to contrib repository.
Expand Down
8 changes: 4 additions & 4 deletions opentelemetry-api/src/opentelemetry/util/types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,10 @@
bool,
int,
float,
Sequence[Optional[str]],
Sequence[Optional[bool]],
Sequence[Optional[int]],
Sequence[Optional[float]],
Sequence[str],
Sequence[bool],
Sequence[int],
Sequence[float],
]
Attributes = Optional[Mapping[str, AttributeValue]]
AttributesAsKey = Tuple[
Expand Down