Skip to content

Add aggregation temporality conversion algorithm #2380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ocelotl merged 16 commits into from
Feb 3, 2022
Merged

Add aggregation temporality conversion algorithm #2380

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
6d49ab1
Implement temporality conversion
ocelotl Jan 15, 2022
ad69a3a
Add aggregation temporality conversion algorithm
ocelotl Jan 15, 2022
b7c6cf7
Fix start_time_unix_nano
ocelotl Jan 18, 2022
fe151a9
Update opentelemetry-sdk/src/opentelemetry/sdk/_metrics/aggregation.py
ocelotl Jan 25, 2022
631c61d
Add warning test
ocelotl Jan 25, 2022
e618fee
Update opentelemetry-sdk/src/opentelemetry/sdk/_metrics/aggregation.py
ocelotl Feb 1, 2022
af623df
Add comments to algorigthm
ocelotl Feb 1, 2022
2014d00
Add check for previous point cumulative aggregation temporality
ocelotl Feb 2, 2022
da98fa2
Added named arguments for gauge
ocelotl Feb 2, 2022
b72aa8e
Change to gauge
ocelotl Feb 2, 2022
abad071
Fix lint
ocelotl Feb 2, 2022
47b2aee
Remove numbers from comment
ocelotl Feb 3, 2022
2c8b73e
Merge branch 'main' into issue_2329
ocelotl Feb 3, 2022
8bdbe49
Update opentelemetry-sdk/src/opentelemetry/sdk/_metrics/aggregation.py
ocelotl Feb 3, 2022
3108293
Revert "Update opentelemetry-sdk/src/opentelemetry/sdk/_metrics/aggre…
ocelotl Feb 3, 2022
52414ea
Merge branch 'main' into issue_2329
Feb 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix start_time_unix_nano
  • Loading branch information
@ocelotl
ocelotl committed Feb 2, 2022
commit b7c6cf77d67c4af426e9a086bbb678cc37a0a5f2
4 changes: 3 additions & 1 deletion opentelemetry-sdk/src/opentelemetry/sdk/_metrics/aggregation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,16 +235,18 @@ def _convert_aggregation_temporality(

if aggregation_temporality == AggregationTemporality.DELTA:
value = current_point.value - previous_point.value
output_start_time_unix_nano = previous_point.time_unix_nano

else:
value = current_point.value + previous_point.value
output_start_time_unix_nano = previous_point.start_time_unix_nano

is_monotonic = (
previous_point.is_monotonic and current_point.is_monotonic
)

return Sum(
start_time_unix_nano=previous_point.start_time_unix_nano,
start_time_unix_nano=output_start_time_unix_nano,
time_unix_nano=current_point.time_unix_nano,
value=value,
aggregation_temporality=aggregation_temporality,
Expand Down
6 changes: 3 additions & 3 deletions opentelemetry-sdk/tests/metrics/test_aggregation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -429,7 +429,7 @@ def test_current_point_sum_aggregation_temporality_delta(self):
AggregationTemporality.DELTA,
),
Sum(
start_time_unix_nano=1,
start_time_unix_nano=2,
time_unix_nano=5,
value=3,
aggregation_temporality=AggregationTemporality.DELTA,
Expand All @@ -456,7 +456,7 @@ def test_current_point_sum_aggregation_temporality_delta(self):
AggregationTemporality.DELTA,
),
Sum(
start_time_unix_nano=1,
start_time_unix_nano=2,
time_unix_nano=5,
value=3,
aggregation_temporality=AggregationTemporality.DELTA,
Expand All @@ -483,7 +483,7 @@ def test_current_point_sum_aggregation_temporality_delta(self):
AggregationTemporality.DELTA,
),
Sum(
start_time_unix_nano=1,
start_time_unix_nano=2,
time_unix_nano=5,
value=3,
aggregation_temporality=AggregationTemporality.DELTA,
Expand Down