Add aggregation temporality conversion algorithm#2380
Merged
ocelotl merged 16 commits intoopen-telemetry:mainfrom Feb 3, 2022
Merged
Add aggregation temporality conversion algorithm#2380ocelotl merged 16 commits intoopen-telemetry:mainfrom
ocelotl merged 16 commits intoopen-telemetry:mainfrom
Conversation
aabmass
reviewed
Jan 18, 2022
opentelemetry-sdk/src/opentelemetry/sdk/_metrics/aggregation.py
Outdated
Show resolved
Hide resolved
opentelemetry-sdk/src/opentelemetry/sdk/_metrics/aggregation.py
Outdated
Show resolved
Hide resolved
ocelotl
added
the
Approve Public API check
srikanthccv
reviewed
Jan 25, 2022
opentelemetry-sdk/src/opentelemetry/sdk/_metrics/aggregation.py
Outdated
Show resolved
Hide resolved
Member
|
I think we should either link to the doc section here in the code, or just copy the explanation into a docstring? |
Co-authored-by: Srikanth Chekuri <srikanth.chekuri92@gmail.com>
Co-authored-by: Aaron Abbott <aaronabbott@google.com>
These comments intend to identify the conditional blocks of the algorithm with the sections defined in the design document.
srikanthccv
approved these changes
Feb 3, 2022
Co-authored-by: Srikanth Chekuri <srikanth.chekuri92@gmail.com>
…gation.py" This reverts commit 8bdbe49.
codeboten
approved these changes
Feb 3, 2022
lzchen
approved these changes
Feb 3, 2022
aabmass
approved these changes
Feb 3, 2022
Member
aabmass
left a comment
aabmass
left a comment
There was a problem hiding this comment.
LGTM, my open comment is a non-blocker if you want to skip it
srikanthccv
approved these changes
Feb 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2329