Fix warning message for OTLP gRPC exporter mixin#2781
Merged
ocelotl merged 7 commits intoopen-telemetry:mainfrom Jul 7, 2022
Merged
Fix warning message for OTLP gRPC exporter mixin#2781ocelotl merged 7 commits intoopen-telemetry:mainfrom
ocelotl merged 7 commits intoopen-telemetry:mainfrom
Conversation
ocelotl
force-pushed
the
issue_2780
branch
3 times, most recently
from
a6c0d6c to
b09fe25
Compare
codeboten
reviewed
Jun 24, 2022
Contributor
codeboten
left a comment
codeboten
left a comment
There was a problem hiding this comment.
I'd recommend adding a changelog with the fix as it's user facing error messages.
lzchen
approved these changes
Jun 24, 2022
srikanthccv
suggested changes
Jun 25, 2022
...pentelemetry-exporter-otlp-proto-grpc/src/opentelemetry/exporter/otlp/proto/grpc/exporter.py
Outdated
Show resolved
Hide resolved
ocelotl
added
the
Approve Public API check
srikanthccv
reviewed
Jun 30, 2022
...pentelemetry-exporter-otlp-proto-grpc/src/opentelemetry/exporter/otlp/proto/grpc/exporter.py
Outdated
Show resolved
Hide resolved
srikanthccv
approved these changes
Jul 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2780