Skip to content

Fix warning message for OTLP gRPC exporter mixin #2781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ocelotl merged 7 commits into from
Jul 7, 2022
Merged

Fix warning message for OTLP gRPC exporter mixin #2781

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
032c33f
Fix warning message for OTLP gRPC exporter mixin
ocelotl Jun 24, 2022
1280a2c
Refactor export parameter type
ocelotl Jun 27, 2022
776cbe1
Add changelog entry
ocelotl Jun 27, 2022
060afd5
Use fixed warning messages for traces and metrics
ocelotl Jun 30, 2022
d2b9829
Use subclass-specific error messages
ocelotl Jul 6, 2022
d2f806b
Fix test cases
ocelotl Jul 6, 2022
f888494
Fix lint
ocelotl Jul 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix test cases
  • Loading branch information
@ocelotl
ocelotl committed Jul 6, 2022
commit d2f806bc949bdd76d454f270e55b01424b594577
2 changes: 1 addition & 1 deletion exporter/opentelemetry-exporter-otlp-proto-grpc/tests/metrics/test_otlp_metrics_exporter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,7 +299,7 @@ def tearDown(self):
self.server.stop(None)

def test_exporting(self):
self.assertEqual(self.exporter.exporting, "metrics")
self.assertEqual(self.exporter._exporting, "metrics")

@patch(
"opentelemetry.exporter.otlp.proto.grpc.exporter.ssl_channel_credentials"
Expand Down
2 changes: 1 addition & 1 deletion exporter/opentelemetry-exporter-otlp-proto-grpc/tests/test_otlp_trace_exporter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,7 @@ def tearDown(self):
self.server.stop(None)

def test_exporting(self):
self.assertEqual(self.exporter.exporting, "traces")
self.assertEqual(self.exporter._exporting, "traces")

@patch.dict(
"os.environ",
Expand Down