Specify to_json indent from arguments#718
Merged
toumorokoshi merged 3 commits intoopen-telemetry:masterfrom May 21, 2020
Merged
Specify to_json indent from arguments#718toumorokoshi merged 3 commits intoopen-telemetry:masterfrom
toumorokoshi merged 3 commits intoopen-telemetry:masterfrom
Conversation
toumorokoshi
approved these changes
May 21, 2020
Member
toumorokoshi
left a comment
toumorokoshi
left a comment
There was a problem hiding this comment.
Thanks! Will approve because this change looks trivial, but at the same time I would suggest a unit test to ensure that your behavior isn't broken in the future as an undocumented use case.
c24t
approved these changes
May 21, 2020
Contributor
Author
|
Will add a unit test and send another PR 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We want to get a json of span without indent, but it's not possible with
Span#to_jsonbecause the method uses hard-coded indent. We currently use a workaround ofjson.loads(span.to_json())which is not efficient in the performance.