Skip to content

Add a unit test for to_json#725

Merged
toumorokoshi merged 7 commits intoopen-telemetry:masterfrom
dtaniwaki:add-to_json-unit-test
May 24, 2020
Merged

Add a unit test for to_json#725
toumorokoshi merged 7 commits intoopen-telemetry:masterfrom
dtaniwaki:add-to_json-unit-test

Conversation

@dtaniwaki
Copy link
Copy Markdown
Contributor

This is the followup issue of #718.

@dtaniwaki dtaniwaki requested a review from a team May 22, 2020 03:13
Copy link
Copy Markdown
Member

@toumorokoshi toumorokoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@dtaniwaki
Copy link
Copy Markdown
Contributor Author

dtaniwaki commented May 23, 2020

Oops, I realized the test method name is wrong. I'm fixing it now.

Copy link
Copy Markdown
Contributor

@ocelotl ocelotl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@toumorokoshi toumorokoshi merged commit c88e585 into open-telemetry:master May 24, 2020
srikanthccv pushed a commit to srikanthccv/opentelemetry-python that referenced this pull request Nov 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants