Skip to content

MX-229: Split the grants in an independent file - #108

Merged
IOhacker merged 1 commit into
openMF:developfrom
IOhacker:develop
Apr 8, 2026
Merged

MX-229: Split the grants in an independent file#108
IOhacker merged 1 commit into
openMF:developfrom
IOhacker:develop

Conversation

@IOhacker

@IOhacker IOhacker commented Apr 8, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Chores
    • Reorganized database migration structure for selfservice module permissions.
    • Updated Self Service User role to grant savings account read access through a dedicated migration file.

@IOhacker
IOhacker merged commit 0dfb09e into openMF:develop Apr 8, 2026
1 of 2 checks passed
@coderabbitai

coderabbitai Bot commented Apr 8, 2026

Copy link
Copy Markdown

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 3d63dabd-955f-4110-8dc2-ea4563e646a4

📥 Commits

Reviewing files that changed from the base of the PR and between eb932a5 and cc596e2.

📒 Files selected for processing (3)
  • src/main/resources/db/changelog/tenant/module/selfservice/module-changelog-master.xml
  • src/main/resources/db/changelog/tenant/module/selfservice/parts/001-create-selfserviceuser-initial-schema.xml
  • src/main/resources/db/changelog/tenant/module/selfservice/parts/005-grant-selfservice-savings-account-read-permissions.xml

📝 Walkthrough

Walkthrough

A refactoring of the Self Service User role's READ_SAVINGSACCOUNT permission grant. The permission assignment was moved from an inline changeSet in the initial schema file to a separate dedicated changelog file with improved duplicate prevention logic.

Changes

Cohort / File(s) Summary
Master Changelog Update
src/main/resources/db/changelog/tenant/module/selfservice/module-changelog-master.xml
Added include entry for new savings account read permission changelog.
Schema Refactoring
src/main/resources/db/changelog/tenant/module/selfservice/parts/001-create-selfserviceuser-initial-schema.xml
Removed changeSet ss-0001-13 that granted READ_SAVINGSACCOUNT permission to Self Service User role.
New Permission Grant
src/main/resources/db/changelog/tenant/module/selfservice/parts/005-grant-selfservice-savings-account-read-permissions.xml
Created new changeSet ss-0005-1 to grant READ_SAVINGSACCOUNT permission with NOT EXISTS clause to prevent duplicate entries.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested labels

⏱️ <10 Min Review

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant